Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles fixed in news slider items on the Main page #1437

Merged
merged 2 commits into from
Sep 30, 2024

Conversation

mythter
Copy link
Contributor

@mythter mythter commented Sep 24, 2024

Summary of issue

Stylized font of the text's first paragraph appears on the news item and breaks markup

Summary of change

Font size and weight always static in the paragraph of news slider item

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

@mythter mythter requested review from Michael-Kolpakov, DDeviak and a team September 24, 2024 20:54
@mythter mythter self-assigned this Sep 24, 2024
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
37.5% Coverage on New Code (required ≥ 80%)
3.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@mythter mythter merged commit 5c4c608 into release/1.1.0 Sep 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants