Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added correct description for field with URL transliteration #1436

Merged
merged 8 commits into from
Oct 20, 2024

Conversation

Michael-Kolpakov
Copy link
Contributor

Ticket

Code reviewers

Summary of issue

  • Based on the current field's label, it is not clear what exactly needs to be entered in the field of modal ("Стріткод" and "Новини" sections). Need to the text with a more appropriate one that will better specify what exactly needs to be entered in the field.

Summary of change

  • Now the fields for URL transliteration are correctly labeled and it is clearer what needs to be entered in them.

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

@Michael-Kolpakov Michael-Kolpakov self-assigned this Sep 23, 2024
Copy link

@Michael-Kolpakov Michael-Kolpakov merged commit e86b421 into release/1.1.0 Oct 20, 2024
3 checks passed
@Michael-Kolpakov Michael-Kolpakov deleted the feature/issue-1773 branch October 20, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants