Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Card rounding on Streetcode page removed on width 1024 and lower #1420

Merged
merged 2 commits into from
Sep 22, 2024
Merged

Card rounding on Streetcode page removed on width 1024 and lower #1420

merged 2 commits into from
Sep 22, 2024

Conversation

mythter
Copy link
Contributor

@mythter mythter commented Sep 17, 2024

Summary of issue

The 'Прослухати текст'/'Аудіо на підході' button is cut off at the bottom right

Summary of change

Card rounding on Streetcode page removed on width 1024 and lower

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

@mythter mythter requested review from Michael-Kolpakov, DDeviak and a team September 17, 2024 09:06
@mythter mythter self-assigned this Sep 17, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
11.2% Coverage on New Code (required ≥ 80%)
3.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@sashapanasiuk5 sashapanasiuk5 merged commit c0c8d73 into release/1.1.0 Sep 22, 2024
1 of 2 checks passed
@sashapanasiuk5 sashapanasiuk5 deleted the feature/issue-904 branch September 24, 2024 11:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DDeviak DDeviak DDeviak approved these changes

@Michael-Kolpakov Michael-Kolpakov Michael-Kolpakov approved these changes

@sashapanasiuk5 sashapanasiuk5 sashapanasiuk5 approved these changes

Assignees

@mythter mythter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mythter @sashapanasiuk5 @Michael-Kolpakov @DDeviak