Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added loading indicator while the data is being loaded from the server (admin page) #1404

Merged
merged 8 commits into from
Oct 21, 2024
Merged

Added loading indicator while the data is being loaded from the server (admin page) #1404

merged 8 commits into from
Oct 21, 2024

Conversation

Michael-Kolpakov
Copy link
Contributor

Ticket

Code reviewers

Summary of issue

  • It was not always clear to the user of the administrator page whether the data was being loaded from the server or whether there was no loaded data.

Summary of change

  1. Added loading indicator while the data is being loaded from the server (admin page).
  2. Changed text from English to Ukrainian language in "No Data" sign when no data were gained from the server side.
  3. Changed image in "No Data" sign when no data were gained from the server side.

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

@Michael-Kolpakov Michael-Kolpakov self-assigned this Sep 11, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
44.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@Michael-Kolpakov Michael-Kolpakov merged commit ef347ca into release/1.1.0 Oct 21, 2024
2 of 3 checks passed
@Michael-Kolpakov Michael-Kolpakov deleted the feature/issue-1706 branch October 21, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mythter mythter mythter left review comments

@darkravchuk darkravchuk darkravchuk approved these changes

@ulyasaur ulyasaur ulyasaur approved these changes

@sashapanasiuk5 sashapanasiuk5 sashapanasiuk5 approved these changes

Assignees

@Michael-Kolpakov Michael-Kolpakov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Michael-Kolpakov @sashapanasiuk5 @mythter @ulyasaur @darkravchuk