Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/issue 1447 #1388

Merged
merged 3 commits into from
Oct 10, 2024
Merged

Feature/issue 1447 #1388

merged 3 commits into from
Oct 10, 2024

Conversation

DDeviak
Copy link
Contributor

@DDeviak DDeviak commented Sep 3, 2024

Ticket

Summary of change

  • Separated interfaces for updating and creating News
  • Removed image from News object on update as it not used on backend

CHECK LIST

  • СI passed
  • Сode coverage >=80%
  • PR is reviewed manually
  • All reviewers agreed to merge the PR
  • PR meets all conventions

@DDeviak DDeviak self-assigned this Sep 3, 2024
@DDeviak DDeviak requested a review from a team September 3, 2024 11:43
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
14.9% Coverage on New Code (required ≥ 80%)
9.5% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@Michael-Kolpakov Michael-Kolpakov merged commit 840012d into release/1.1.0 Oct 10, 2024
3 checks passed
@Michael-Kolpakov Michael-Kolpakov deleted the feature/issue-1447 branch October 10, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michael-Kolpakov Michael-Kolpakov Michael-Kolpakov approved these changes

@ulyasaur ulyasaur ulyasaur approved these changes

@mythter mythter mythter approved these changes

Assignees

@DDeviak DDeviak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DDeviak @mythter @ulyasaur @Michael-Kolpakov