Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emails limit message not showing fixed #1387

Merged
merged 3 commits into from
Sep 27, 2024
Merged

Conversation

mythter
Copy link
Contributor

@mythter mythter commented Sep 2, 2024

Code reviewers

Summary of issue

The wrong error message appears after sending 3 forms in 5 minutes from same IP address on the 'Contact us' page

Summary of change

Correct message is displayed when emails limit is reached

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

Copy link

sonarqubecloud bot commented Sep 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
14.9% Coverage on New Code (required ≥ 80%)
9.5% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@mythter mythter self-assigned this Sep 4, 2024
@mythter mythter requested a review from a team September 26, 2024 20:41
@mythter mythter merged commit d5a568a into release/1.1.0 Sep 27, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants