Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu slider fixed when unknown path #1386

Merged
merged 2 commits into from
Sep 30, 2024
Merged

Conversation

mythter
Copy link
Contributor

@mythter mythter commented Sep 2, 2024

Code reviewers

Summary of issue

The square of the vertical line is not opposite of the menu item 'Головна' when News openned

Summary of change

  • Menu slider position now at the beggining when path doesn't match any menu item
  • Menu slider at the Streetcodes menu position if any streetcode is open

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

@mythter mythter self-assigned this Sep 2, 2024
Copy link

sonarqubecloud bot commented Sep 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
14.8% Coverage on New Code (required ≥ 80%)
9.5% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@mythter mythter requested review from DDeviak and a team September 26, 2024 20:41
@mythter mythter merged commit 85a5a55 into release/1.1.0 Sep 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants