Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate performance issues and request processing status indicator #1384

Merged
merged 2 commits into from
Oct 10, 2024

Conversation

Michael-Kolpakov
Copy link
Contributor

@Michael-Kolpakov Michael-Kolpakov commented Sep 1, 2024

Ticket

Code reviewers

Summary of issue

  1. Catalogs upload in at least 3 minutes.
  2. The modal window doesn't close.

Summary of change

  1. After long investigations any problems with uploading speed were not detected. Probably, when author of ticket tested application was problems with server performance, but now everything works fine.
  2. Added an explicit loading indicator that will be displayed until all necessary requests are completed. This helps user of admin page get better understanding that app is working and he need to wait a couple of seconds.

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

Copy link

sonarqubecloud bot commented Sep 1, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
14.9% Coverage on New Code (required ≥ 80%)
9.5% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@Michael-Kolpakov Michael-Kolpakov self-assigned this Sep 7, 2024
Copy link

@Michael-Kolpakov Michael-Kolpakov merged commit 2535ebe into release/1.1.0 Oct 10, 2024
3 checks passed
@Michael-Kolpakov Michael-Kolpakov deleted the feature/issue-1482 branch October 10, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants