Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Social icons drop-shadow fixed in ContactForm #1372

Merged
merged 3 commits into from
Sep 30, 2024
Merged

Social icons drop-shadow fixed in ContactForm #1372

merged 3 commits into from
Sep 30, 2024

Conversation

mythter
Copy link
Contributor

@mythter mythter commented Aug 27, 2024 •
edited by Michael-Kolpakov
Loading

Code reviewers

Summary of issue

Social icons drop-shadow fixed in Contact Form according to the mockup

Summary of change

  • drop-shadow color of social icons changed

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

@mythter mythter requested review from sashapanasiuk5, Michael-Kolpakov and a team August 27, 2024 12:19
@mythter mythter self-assigned this Aug 27, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
14.9% Coverage on New Code (required ≥ 80%)
9.5% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@mythter mythter requested review from DDeviak and a team September 26, 2024 19:45
@mythter mythter requested a review from a team September 30, 2024 08:29
@mythter mythter merged commit cf8eb9b into release/1.1.0 Sep 30, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michael-Kolpakov Michael-Kolpakov Michael-Kolpakov approved these changes

@ulyasaur ulyasaur ulyasaur approved these changes

@sashapanasiuk5 sashapanasiuk5 sashapanasiuk5 approved these changes

@DDeviak DDeviak Awaiting requested review from DDeviak

Assignees

@mythter mythter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mythter @sashapanasiuk5 @ulyasaur @Michael-Kolpakov