Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Removed popover on PartnersModal component #1370

Merged
merged 2 commits into from
Sep 29, 2024
Merged

chore: Removed popover on PartnersModal component #1370

merged 2 commits into from
Sep 29, 2024

Conversation

DDeviak
Copy link
Contributor

@DDeviak DDeviak commented Aug 25, 2024

Ticket

Summary of change

Removed popover on PartnersModal component

Illustration

image

CHECK LIST

  • СI passed
  • Сode coverage >=80%
  • PR is reviewed manually
  • All reviewers agreed to merge the PR
  • PR meets all conventions

@DDeviak DDeviak requested a review from a team August 25, 2024 15:28
@DDeviak DDeviak self-assigned this Aug 25, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
14.9% Coverage on New Code (required ≥ 80%)
9.5% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@sashapanasiuk5 sashapanasiuk5 merged commit 44f7066 into release/1.1.0 Sep 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Michael-Kolpakov Michael-Kolpakov Michael-Kolpakov approved these changes

@mythter mythter mythter approved these changes

@sashapanasiuk5 sashapanasiuk5 sashapanasiuk5 approved these changes

Assignees

@DDeviak DDeviak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DDeviak @sashapanasiuk5 @mythter @Michael-Kolpakov