Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/issue-1471 #1359

Merged
merged 17 commits into from
Oct 16, 2024
Merged

feature/issue-1471 #1359

merged 17 commits into from
Oct 16, 2024

Conversation

nazar-mykhailenko
Copy link
Contributor

@nazar-mykhailenko nazar-mykhailenko commented Aug 8, 2024

Changes made:

made save button disabled after saving changes and enable right after any input change in these modals:

  • "Додати нову вакансію"
  • "Хронологія"
  • "Для фанатів"
  • "Створити/Додати партнера"
  • "Додати нову категорію"/ "Додати новий тег"/"Додати новий контекст"
  • "Створити новину"

dev

JIRA

Code reviewers

  • @github_username

Second Level Review

  • @github_username

Summary of issue

ToDo

Summary of change

ToDo

Testing approach

ToDo

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

@DDeviak DDeviak self-assigned this Aug 8, 2024
@DDeviak
Copy link
Contributor

DDeviak commented Aug 23, 2024

Added unit tests for all those stuff

@DDeviak
Copy link
Contributor

DDeviak commented Oct 1, 2024

Also solves "categories" part of ita-social-projects/StreetCode#949

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
8.7% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants