Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make save button disabled after save in Team modal #1358

Merged
merged 12 commits into from
Oct 20, 2024

Conversation

nazar-mykhailenko
Copy link
Contributor

@nazar-mykhailenko nazar-mykhailenko commented Aug 8, 2024

Changes made:

made save button disabled after saving changes and enable right after any input change in the TeamModal

dev

JIRA

Code reviewers

  • @github_username

Second Level Review

  • @github_username

Summary of issue

ToDo

Summary of change

ToDo

Testing approach

ToDo

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

config/webpack.dev.js Outdated Show resolved Hide resolved
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
14.9% Coverage on New Code (required ≥ 80%)
9.5% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@DDeviak DDeviak force-pushed the feature/issue-1539 branch from 52f05fa to 2aedd15 Compare October 1, 2024 19:58
Copy link

@Michael-Kolpakov Michael-Kolpakov merged commit 08b8053 into release/1.1.0 Oct 20, 2024
3 checks passed
@Michael-Kolpakov Michael-Kolpakov deleted the feature/issue-1539 branch October 20, 2024 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants