Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 1009 #1357

Merged
merged 4 commits into from
Sep 29, 2024
Merged

Feature/issue 1009 #1357

merged 4 commits into from
Sep 29, 2024

Conversation

sashapanasiuk5
Copy link
Contributor

dev

JIRA

Code reviewers

  • @github_username

Second Level Review

  • @github_username

Summary of issue

The modal window does not according to the mockup

Summary of change

ToDo

Testing approach

ToDo

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

Copy link

sonarqubecloud bot commented Aug 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
14.9% Coverage on New Code (required ≥ 80%)
9.5% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@sashapanasiuk5 sashapanasiuk5 merged commit 9ef8037 into release/1.1.0 Sep 29, 2024
2 checks passed
@sashapanasiuk5 sashapanasiuk5 deleted the feature/issue-1009 branch September 29, 2024 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants