Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/issue 839 #1356

Merged
merged 3 commits into from
Sep 29, 2024
Merged

Feature/issue 839 #1356

merged 3 commits into from
Sep 29, 2024

Conversation

DDeviak
Copy link
Contributor

@DDeviak DDeviak commented Aug 7, 2024

Ticket

Summary of change

  • Removed white lines on the sides of swiper
  • Added navigational dots

Illustartion

image

CHECK LIST

  • СI passed
  • Сode coverage >=80%
  • PR is reviewed manually
  • All reviewers agreed to merge the PR
  • PR meets all conventions

@DDeviak DDeviak requested review from ulyasaur, darkravchuk, DmytroHoliaka and a team August 7, 2024 13:06
@DDeviak DDeviak self-assigned this Aug 7, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
14.9% Coverage on New Code (required ≥ 80%)
9.5% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@sashapanasiuk5 sashapanasiuk5 merged commit 17cd47a into release/1.1.0 Sep 29, 2024
2 checks passed
@sashapanasiuk5 sashapanasiuk5 deleted the feature/issue-839 branch September 29, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmytroHoliaka DmytroHoliaka DmytroHoliaka approved these changes

@darkravchuk darkravchuk darkravchuk approved these changes

@ulyasaur ulyasaur ulyasaur approved these changes

@mythter mythter mythter approved these changes

Assignees

@DDeviak DDeviak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@DDeviak @mythter @ulyasaur @darkravchuk @DmytroHoliaka @sashapanasiuk5