Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/issue 1597 #1345

Merged
merged 13 commits into from
Oct 7, 2024
Merged

Feature/issue 1597 #1345

merged 13 commits into from
Oct 7, 2024

Conversation

DDeviak
Copy link
Contributor

@DDeviak DDeviak commented Aug 1, 2024

Ticket

Summary of change

  • Added unified uniqueness validator to use in forms.
  • Fixed messages on items editing.

Such logic was implemented in modals on Categories, Tags, Contexts and Positions pages:

  • Check for title uniqueness.
  • Prevent user from typing more than one whitespace continuously.
  • Trim trailing whitespaces on title save and validation.

CHECK LIST

  • СI passed
  • Сode coverage >=80%
  • PR is reviewed manually
  • All reviewers agreed to merge the PR
  • PR meets all conventions

@DDeviak DDeviak requested review from ulyasaur, darkravchuk, DmytroHoliaka and a team August 1, 2024 15:38
@DDeviak DDeviak self-assigned this Aug 1, 2024
@DDeviak DDeviak force-pushed the feature/issue-1597 branch from 83c8a8e to 1223ba5 Compare August 5, 2024 15:53
Copy link

sonarqubecloud bot commented Aug 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
15.9% Coverage on New Code (required ≥ 80%)
9.5% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@sashapanasiuk5 sashapanasiuk5 merged commit 9d379c1 into release/1.1.0 Oct 7, 2024
2 checks passed
@sashapanasiuk5 sashapanasiuk5 deleted the feature/issue-1597 branch October 7, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants