Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audio keeps playing while navigating the site #1336

Merged
merged 14 commits into from
Aug 3, 2024
Merged

Audio keeps playing while navigating the site #1336

merged 14 commits into from
Aug 3, 2024

Conversation

mythter
Copy link
Contributor

@mythter mythter commented Jul 29, 2024

  1. Fixed audio modal hides while navigating the site
  2. Fixed site reloading while navigating some pages
  3. Fixed double click on close audio modal not actually closing
  4. Fixed random blink when audio modal ends closing
  5. Fixed search block not hiding and clearing when clicked on search item
    Ticket: #1286

mythter added 10 commits July 29, 2024 23:04
@mythter
feat: majority of <a> and window.location.href replaced with <Link> o…
8fe57b1 
…r Navigate
@mythter
feat: ListenTextModal moved to App
e60ffa1
@mythter
feat: Audio modal does not hide if already open and clicked on 'Просл…
de9d73e 
…ухати текст'
@mythter
feat: double click on Close button in Audio modal bug fixed
88900d8
@mythter
feat: random blink in the end of Audio modal closing fixed
421e131
@mythter
feat: useMobx returned to StreetCodeCatalogItem
ab5cfee
@mythter
feat: fixed bug when redirect from streetcode to another streecode no…
1ac547a 
…t updated content
@mythter
feat: play/pause methods added to AudioPlayer and some cancel/request…
3796211 
… AnimationFrame bugs fixed
@mythter
feat: keep audio state when navigating the site bug fixed
66f242a
@mythter
feat: click on search result clears and hides search input
b2875b8
@mythter mythter force-pushed the feature/issue-1286 branch from f305b95 to 5bd236e Compare July 30, 2024 10:41
@mythter mythter changed the base branch from release/1.1.0 to release/1.0.0 July 30, 2024 12:27
@mythter mythter changed the base branch from release/1.0.0 to release/1.1.0 July 30, 2024 12:33
@mythter mythter force-pushed the feature/issue-1286 branch from 535085a to c67ec7a Compare July 30, 2024 13:28
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
15.0% Coverage on New Code (required ≥ 80%)
9.6% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@ulyasaur ulyasaur merged commit 5b7dd24 into release/1.1.0 Aug 3, 2024
1 of 2 checks passed
@mythter mythter self-assigned this Aug 25, 2024
This was referenced Aug 27, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmytroHoliaka DmytroHoliaka DmytroHoliaka approved these changes

@NastiaVeret NastiaVeret NastiaVeret approved these changes

@ulyasaur ulyasaur ulyasaur approved these changes

@darkravchuk darkravchuk Awaiting requested review from darkravchuk

Assignees

@mythter mythter

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mythter @ulyasaur @NastiaVeret @DmytroHoliaka