Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/issue 1463 2 #1297

Merged
merged 3 commits into from
Jun 9, 2024
Merged

Feature/issue 1463 2 #1297

merged 3 commits into from
Jun 9, 2024

Conversation

yaakymiv
Copy link
Contributor

@yaakymiv yaakymiv commented Jun 9, 2024

Issue:

I found just 1 edge case - placing one symbol and erasing it

Fix:

Added prev state

@yaakymiv yaakymiv linked an issue Jun 9, 2024 that may be closed by this pull request
[Admin/StreetCode/Авторство] [API] The admin can add text in the 'Авторство' block if no main text is added ita-social-projects/StreetCode#1463
Open
@yaakymiv yaakymiv changed the base branch from master to release/1.0.0 June 9, 2024 09:26
@yaakymiv yaakymiv requested review from NastiaVeret and BapBap7 June 9, 2024 09:27
@yaakymiv yaakymiv requested a review from Lazy-Lenny June 9, 2024 10:06
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
14.7% Coverage on New Code (required ≥ 80%)
8.8% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@NastiaVeret NastiaVeret merged commit 8f9b916 into release/1.0.0 Jun 9, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BapBap7 BapBap7 BapBap7 approved these changes

@NastiaVeret NastiaVeret NastiaVeret approved these changes

@Lazy-Lenny Lazy-Lenny Lazy-Lenny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@yaakymiv @Lazy-Lenny @NastiaVeret @BapBap7