Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: the user cant copy the text in the card #1165

Closed
wants to merge 9 commits into from
Closed

bug: the user cant copy the text in the card #1165

wants to merge 9 commits into from

Conversation

maxvonlancaster
Copy link
Member

@maxvonlancaster maxvonlancaster commented Feb 26, 2024 •
edited
Loading

dev

JIRA

Code reviewers

Second Level Review

  • [ ]

Issue:

  • User can not copy text on click on description cards

Summary of change

  • Added handler, that sets text to navigator.clipboard

Testing approach

  • manually tested locally

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

Oleh-Kril
Oleh-Kril reviewed Feb 26, 2024
View reviewed changes
Copy link
Contributor

@Oleh-Kril Oleh-Kril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation is working, but in my mind it lacks quality UX

@maxvonlancaster maxvonlancaster changed the base branch from master to develop February 26, 2024 18:18
@maxvonlancaster
Copy link
Member Author

Implementation is working, but in my mind it lacks quality UX

Found implementation of UX for copying of text in codebase, reused it

image

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@IvannYad IvannYad deleted the bug/copy-card-text branch March 13, 2024 13:45
@KateYatsiuk KateYatsiuk mentioned this pull request Aug 5, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oleh-Kril Oleh-Kril Oleh-Kril left review comments

@Rominos7 Rominos7 Rominos7 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@maxvonlancaster @Rominos7 @Oleh-Kril @IvannYad @BohdanBybliv