Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update master #1044

Merged
merged 6 commits into from
Jan 11, 2024
Merged

Update master #1044

merged 6 commits into from
Jan 11, 2024

Conversation

Oleh-Kril
Copy link
Contributor

dev

JIRA

Code reviewers

  • @github_username

Second Level Review

  • @github_username

Summary of issue

ToDo

Summary of change

ToDo

Testing approach

ToDo

CHECK LIST

  • СI passed
  • Сode coverage >=95%
  • PR is reviewed manually again (to make sure you have 100% ready code)
  • All reviewers agreed to merge the PR
  • I've checked new feature as logged in and logged out user if needed
  • PR meets all conventions

IvannYad and others added 6 commits January 3, 2024 22:11
* Fixed seeding

* Fixed inability to update streetcode 1

* Fixed additional text
* add swagger for stage and local

* Changed datestring max length to 100 instead of 50 (#901) (#933)

* fix sonar

* Update fix sonar

---------

Co-authored-by: Vitalii <[email protected]>
Co-authored-by: Andrii Malynovskyi <[email protected]>
Co-authored-by: Adeodonne <[email protected]>
Co-authored-by: Bohdan Bozhyk <[email protected]>
@Oleh-Kril Oleh-Kril merged commit 214b2a4 into master Jan 11, 2024
3 of 4 checks passed
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

13.0% Coverage on New Code (required ≥ 80%)
16.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Oleh-Kril added a commit that referenced this pull request Jan 11, 2024
* Update 'Setup' section in README.md

* Add 'TrustServerCertificate=true' to connection string template

* Fixed seeding (#872)

* Fixed seeding

* Fixed inability to update streetcode 1

* Fixed additional text

* Changed job description length limit (#1006)

* Fix sonarcloud 3 (#970)

* add swagger for stage and local

* Changed datestring max length to 100 instead of 50 (#901) (#933)

* fix sonar

* Update fix sonar

---------






---------

Co-authored-by: BohdanBybliv <[email protected]>
Co-authored-by: Ivan Yadchyshyn <[email protected]>
Co-authored-by: Ivan Yadchyshyn <[email protected]>
Co-authored-by: Andrii Malynovskyi <[email protected]>
Co-authored-by: Kateryna Yatsiuk <[email protected]>
Co-authored-by: Valentyn Zamykhivskyi <[email protected]>
Co-authored-by: Vitalii <[email protected]>
Co-authored-by: Adeodonne <[email protected]>
Co-authored-by: Bohdan Bozhyk <[email protected]>
Oleh-Kril added a commit that referenced this pull request Jan 22, 2024
* Update 'Setup' section in README.md

* Add 'TrustServerCertificate=true' to connection string template

* Fixed seeding (#872)

* Fixed seeding

* Fixed inability to update streetcode 1

* Fixed additional text

* Changed job description length limit (#1006)

* Fix sonarcloud 3 (#970)

* add swagger for stage and local

* Changed datestring max length to 100 instead of 50 (#901) (#933)

* fix sonar

* Update fix sonar

---------






---------

Co-authored-by: BohdanBybliv <[email protected]>
Co-authored-by: Ivan Yadchyshyn <[email protected]>
Co-authored-by: Ivan Yadchyshyn <[email protected]>
Co-authored-by: Andrii Malynovskyi <[email protected]>
Co-authored-by: Kateryna Yatsiuk <[email protected]>
Co-authored-by: Valentyn Zamykhivskyi <[email protected]>
Co-authored-by: Vitalii <[email protected]>
Co-authored-by: Adeodonne <[email protected]>
Co-authored-by: Bohdan Bozhyk <[email protected]>
Oleh-Kril added a commit that referenced this pull request Jan 22, 2024
* Update 'Setup' section in README.md

* Add 'TrustServerCertificate=true' to connection string template

* Fixed seeding (#872)

* Fixed seeding

* Fixed inability to update streetcode 1

* Fixed additional text

* Changed job description length limit (#1006)

* Fix sonarcloud 3 (#970)

* add swagger for stage and local

* Changed datestring max length to 100 instead of 50 (#901) (#933)

* fix sonar

* Update fix sonar

---------

Co-authored-by: Vitalii <[email protected]>
Co-authored-by: Andrii Malynovskyi <[email protected]>
Co-authored-by: Adeodonne <[email protected]>
Co-authored-by: Bohdan Bozhyk <[email protected]>

* Update master (#1044) (#1045)

* Update 'Setup' section in README.md

* Add 'TrustServerCertificate=true' to connection string template

* Fixed seeding (#872)

* Fixed seeding

* Fixed inability to update streetcode 1

* Fixed additional text

* Changed job description length limit (#1006)

* Fix sonarcloud 3 (#970)

* add swagger for stage and local

* Changed datestring max length to 100 instead of 50 (#901) (#933)

* fix sonar

* Update fix sonar

---------






---------

Co-authored-by: BohdanBybliv <[email protected]>
Co-authored-by: Ivan Yadchyshyn <[email protected]>
Co-authored-by: Ivan Yadchyshyn <[email protected]>
Co-authored-by: Andrii Malynovskyi <[email protected]>
Co-authored-by: Kateryna Yatsiuk <[email protected]>
Co-authored-by: Valentyn Zamykhivskyi <[email protected]>
Co-authored-by: Vitalii <[email protected]>
Co-authored-by: Adeodonne <[email protected]>
Co-authored-by: Bohdan Bozhyk <[email protected]>

* Integration test cases Create Streetcode (#975)

* Add some test cases

* Add intagration tast cases for Streetcode create.

* Add some changes

* Fixed test case with StreetcodeCreateDTO

* Correct appSettings

* Fix All integration tests after merging with develop

* Adjusted remarks

* fix docker file (#1072)

* revert swagger (#1075)

* fix swagger (#1088)

* trim query before getting from db (#1052)

* Update master (#1044) (#1045)

* Update 'Setup' section in README.md

* Add 'TrustServerCertificate=true' to connection string template

* Fixed seeding (#872)

* Fixed seeding

* Fixed inability to update streetcode 1

* Fixed additional text

* Changed job description length limit (#1006)

* Fix sonarcloud 3 (#970)

* add swagger for stage and local

* Changed datestring max length to 100 instead of 50 (#901) (#933)

* fix sonar

* Update fix sonar

---------






---------

Co-authored-by: BohdanBybliv <[email protected]>
Co-authored-by: Ivan Yadchyshyn <[email protected]>
Co-authored-by: Ivan Yadchyshyn <[email protected]>
Co-authored-by: Andrii Malynovskyi <[email protected]>
Co-authored-by: Kateryna Yatsiuk <[email protected]>
Co-authored-by: Valentyn Zamykhivskyi <[email protected]>
Co-authored-by: Vitalii <[email protected]>
Co-authored-by: Adeodonne <[email protected]>
Co-authored-by: Bohdan Bozhyk <[email protected]>

* Integration test cases Create Streetcode (#975)

* Add some test cases

* Add intagration tast cases for Streetcode create.

* Add some changes

* Fixed test case with StreetcodeCreateDTO

* Correct appSettings

* Fix All integration tests after merging with develop

* Adjusted remarks

* trim query before getting from db (#1052)

---------

Co-authored-by: Ivan Yadchyshyn <[email protected]>
Co-authored-by: Ivan Yadchyshyn <[email protected]>
Co-authored-by: Andrii Malynovskyi <[email protected]>
Co-authored-by: Kateryna Yatsiuk <[email protected]>
Co-authored-by: Valentyn Zamykhivskyi <[email protected]>
Co-authored-by: Vitalii <[email protected]>
Co-authored-by: Adeodonne <[email protected]>
Co-authored-by: Bohdan Bozhyk <[email protected]>
Co-authored-by: BohdanBybliv <[email protected]>
Co-authored-by: Valerii Dekhtiyk <[email protected]>
Oleh-Kril added a commit that referenced this pull request Jan 23, 2024
* Update 'Setup' section in README.md

* Add 'TrustServerCertificate=true' to connection string template

* Fixed seeding (#872)

* Fixed seeding

* Fixed inability to update streetcode 1

* Fixed additional text

* Changed job description length limit (#1006)

* Fix sonarcloud 3 (#970)

* add swagger for stage and local

* Changed datestring max length to 100 instead of 50 (#901) (#933)

* fix sonar

* Update fix sonar

---------

Co-authored-by: Vitalii <[email protected]>
Co-authored-by: Andrii Malynovskyi <[email protected]>
Co-authored-by: Adeodonne <[email protected]>
Co-authored-by: Bohdan Bozhyk <[email protected]>

* Update master (#1044) (#1045)

* Update 'Setup' section in README.md

* Add 'TrustServerCertificate=true' to connection string template

* Fixed seeding (#872)

* Fixed seeding

* Fixed inability to update streetcode 1

* Fixed additional text

* Changed job description length limit (#1006)

* Fix sonarcloud 3 (#970)

* add swagger for stage and local

* Changed datestring max length to 100 instead of 50 (#901) (#933)

* fix sonar

* Update fix sonar

---------






---------

Co-authored-by: BohdanBybliv <[email protected]>
Co-authored-by: Ivan Yadchyshyn <[email protected]>
Co-authored-by: Ivan Yadchyshyn <[email protected]>
Co-authored-by: Andrii Malynovskyi <[email protected]>
Co-authored-by: Kateryna Yatsiuk <[email protected]>
Co-authored-by: Valentyn Zamykhivskyi <[email protected]>
Co-authored-by: Vitalii <[email protected]>
Co-authored-by: Adeodonne <[email protected]>
Co-authored-by: Bohdan Bozhyk <[email protected]>

* Integration test cases Create Streetcode (#975)

* Add some test cases

* Add intagration tast cases for Streetcode create.

* Add some changes

* Fixed test case with StreetcodeCreateDTO

* Correct appSettings

* Fix All integration tests after merging with develop

* Adjusted remarks

* fix docker file (#1072)

* revert swagger (#1075)

* fix swagger (#1088)

* trim query before getting from db (#1052)

* Update master (#1044) (#1045)

* Update 'Setup' section in README.md

* Add 'TrustServerCertificate=true' to connection string template

* Fixed seeding (#872)

* Fixed seeding

* Fixed inability to update streetcode 1

* Fixed additional text

* Changed job description length limit (#1006)

* Fix sonarcloud 3 (#970)

* add swagger for stage and local

* Changed datestring max length to 100 instead of 50 (#901) (#933)

* fix sonar

* Update fix sonar

---------






---------

Co-authored-by: BohdanBybliv <[email protected]>
Co-authored-by: Ivan Yadchyshyn <[email protected]>
Co-authored-by: Ivan Yadchyshyn <[email protected]>
Co-authored-by: Andrii Malynovskyi <[email protected]>
Co-authored-by: Kateryna Yatsiuk <[email protected]>
Co-authored-by: Valentyn Zamykhivskyi <[email protected]>
Co-authored-by: Vitalii <[email protected]>
Co-authored-by: Adeodonne <[email protected]>
Co-authored-by: Bohdan Bozhyk <[email protected]>

* Integration test cases Create Streetcode (#975)

* Add some test cases

* Add intagration tast cases for Streetcode create.

* Add some changes

* Fixed test case with StreetcodeCreateDTO

* Correct appSettings

* Fix All integration tests after merging with develop

* Adjusted remarks

* trim query before getting from db (#1052)

* optimize query (#1100)

* adjust time from every minute from 3 to 4 am -> one time at 3 am (#1077)

* adjust time from every minute from 3 to 4 am -> one time at 3 am

* adjust production settings

* Middleware Implementation (#323)

* Middleware Implementation

* modified properties to ignore, length to ignore, and added additional functionallity to not cut some props, divided some methods, fixed problem with case letters.

* Added Option pattern to Middleware

* Refactored request-response middleware

* added "ToLower" check in program.cs

* Update Streetcode/Streetcode.BLL/Middleware/ApiRequestResponseMiddleware.cs

Co-authored-by: Maxym <[email protected]>

* change "if" statement structure

* Cleaned redundant files

* Fixed middleware

* Fixed middleware

* Fixed DI for middleware and registered serilog

* fix csproj syntax

* - bring back logerService
- make project work

* fix recursion and refactor shortening

---------

Co-authored-by: Maxym Lanchevych <[email protected]>
Co-authored-by: Maxym <[email protected]>
Co-authored-by: Oleh-Kril <[email protected]>

---------

Co-authored-by: Ivan Yadchyshyn <[email protected]>
Co-authored-by: Ivan Yadchyshyn <[email protected]>
Co-authored-by: Andrii Malynovskyi <[email protected]>
Co-authored-by: Kateryna Yatsiuk <[email protected]>
Co-authored-by: Valentyn Zamykhivskyi <[email protected]>
Co-authored-by: Vitalii <[email protected]>
Co-authored-by: Adeodonne <[email protected]>
Co-authored-by: Bohdan Bozhyk <[email protected]>
Co-authored-by: BohdanBybliv <[email protected]>
Co-authored-by: Valerii Dekhtiyk <[email protected]>
Co-authored-by: Dmytro Hranovskyi <[email protected]>
Co-authored-by: Maxym Lanchevych <[email protected]>
Co-authored-by: Maxym <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants