Added redirect to chat #2998
Open
Added redirect to chat #2998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Renatavl
commented
Dec 18, 2024
•
Renatavl
commented
- Added redirect to chat;
- Added tests to increase test coverage
Renatavl
added
Frontend part
feature
Student
Renatavl
requested review from
dudchakk,
ShadowOfTheSpace,
markgol777,
Made1ra,
Mav-Ivan,
Mike-Popovych,
luiqor and
nebby2105
Renatavl
force-pushed
the
feature/1681/redirect-to-chat
branch
5 times, most recently
from
c9f7f19 to
7a8aa09
Compare
Renatavl
force-pushed
the
feature/1681/redirect-to-chat
branch
from
7a8aa09 to
af62560
Compare
|
ShadowOfTheSpace
requested changes
Dec 19, 2024
| @@ -37,6 +42,8 @@ interface ProfileInfoProps { | |||
| const ProfileInfo = ({ userData, myRole }: ProfileInfoProps) => { | |||
| const { t } = useTranslation() | |||
| const navigate = useNavigate() | |||
| const { setChatInfo } = useChatContext() | |||
| const getChats = useCallback(() => chatService.getChats(), []) | |||
There was a problem hiding this comment.
You can pass just chatService.getChats to service prop of useAxios hook
| response: listOfChats, | ||
| loading: isChatsLoading, | ||
| fetchData | ||
| } = useAxios({ |
There was a problem hiding this comment.
Add generic type to the useAxios hook, and you will not have that weird types assertions in finding existing chat, because right now listOfChats has never type
Suggested change
| } = useAxios({ | |
| } = useAxios<ChatResponse[]>({ |
| setChatInfo({ | ||
| author: userData, | ||
| authorRole: userData.role[0] as UserRoleEnum.Student | UserRoleEnum.Tutor, | ||
| chatId: existedChat?._id || '', |
There was a problem hiding this comment.
Suggested change
| chatId: existedChat?._id || '', | |
| chatId: existedChat?._id ?? '', |
| }) | ||
|
|
||
| const onSendMessageClick = () => { | ||
| const existedChat = listOfChats.find((chat: ChatResponse) => |
There was a problem hiding this comment.
Add curly braces to this function, because it doesn't fit into a single line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.