Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated AcceptCooperationClosing #2993

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

updated AcceptCooperationClosing #2993

wants to merge 8 commits into from
+253 −70

Conversation

nebby2105
Copy link
Contributor

@nebby2105 nebby2105 commented Dec 17, 2024 •
edited
Loading

Updated AcceptCooperationClosing banner enabling users to either accept a cooperation agreement or decline it with an optional reason. #2958

Accept button triggers the onAccept callback for proceeding with the cooperation.
Decline button toggles the input field visibility.

Screenshot 2024-12-18 at 21 42 05
  • The input field is displayed only when the user clicks the Decline button.
  • Focus is automatically applied to the input field upon rendering.
Screenshot 2024-12-18 at 21 42 16

without focus:
Screenshot 2024-12-18 at 21 42 25

  • Validation ensures the input field is not left empty when clicking on Submit button.
  • Displays a helper text to inform users about input errors.
Screenshot 2024-12-18 at 21 42 36
  • After submitting success message is being shown.
Screenshot 2024-12-18 at 21 42 49
  • Added a Decline button to trigger the decline workflow.
  • Implemented a form for entering the reason for declining cooperation.
  • Displayed a success message after submitting the decline reason.
  • Updated InputField to use forwardRef

@nebby2105 nebby2105 self-assigned this Dec 17, 2024
ShadowOfTheSpace
ShadowOfTheSpace requested changes Dec 17, 2024
View reviewed changes
src/containers/my-cooperations/accept-cooperation-close/AcceptCooperationClosing.tsx Outdated Show resolved Hide resolved
src/containers/my-cooperations/accept-cooperation-close/AcceptCooperationClosing.tsx Outdated Show resolved Hide resolved
src/containers/my-cooperations/accept-cooperation-close/AcceptCooperationClosing.tsx Outdated Show resolved Hide resolved
src/containers/my-cooperations/accept-cooperation-close/AcceptCooperationClosing.tsx Outdated Show resolved Hide resolved
src/containers/my-cooperations/accept-cooperation-close/AcceptCooperationClosing.tsx Outdated Show resolved Hide resolved
src/containers/my-cooperations/accept-cooperation-close/AcceptCooperationClosing.tsx Outdated Show resolved Hide resolved
src/containers/my-cooperations/accept-cooperation-close/AcceptCooperationClosing.styles.ts Outdated Show resolved Hide resolved
src/containers/my-cooperations/accept-cooperation-close/AcceptCooperationClosing.styles.ts Outdated Show resolved Hide resolved
src/containers/my-cooperations/accept-cooperation-close/AcceptCooperationClosing.styles.ts Outdated Show resolved Hide resolved
src/containers/my-cooperations/accept-cooperation-close/AcceptCooperationClosing.styles.ts Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nebby2105 nebby2105 marked this pull request as ready for review December 18, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amoutens amoutens Awaiting requested review from amoutens

@dudchakk dudchakk Awaiting requested review from dudchakk

@ArtemHolikov ArtemHolikov Awaiting requested review from ArtemHolikov

@luiqor luiqor Awaiting requested review from luiqor

@ShadowOfTheSpace ShadowOfTheSpace Awaiting requested review from ShadowOfTheSpace

Requested changes must be addressed to merge this pull request.

Assignees

@nebby2105 nebby2105

Labels
Frontend part
Projects
SpaceToStudy
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nebby2105 @ShadowOfTheSpace