Create Menu component #2990
Open
Create Menu component #2990
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luiqor
requested review from
markgol777,
Made1ra,
OFrankov,
SofiiaYevush and
RomanRozbytskyi
ShadowOfTheSpace
requested changes
Dec 17, 2024
Comment on lines
+37
to
+47
| if (graphicsRef.current) { | ||
| const interactiveElement = | ||
| graphicsRef.current.querySelector<HTMLInputElement>( | ||
| 'input[type="radio"], input[type="checkbox"], [role="radio"], [role="checkbox"]' | ||
| ) | ||
|
|
||
| if (interactiveElement) { | ||
| interactiveElement.click() | ||
| return | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we get same result with using the element? Its default behaviour that it is clicking on input that currently inside the label.
There was a problem hiding this comment.
If you mean like that:
const handleClick = () => {
if (graphicsRef.current) {
graphicsRef.current.click()
return
}
onClick?.()
}
: unfortunately, checkbox then is not marked as selected on click.
When I am changing the button tag to label here, I can't get rid of onClick triggering two times, even with event.stopPropagation()
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Menu Component
Disabled / Selected / Hovered as in old design
Simple dropdown menu
Menu with checkboxes
Nested dropdowns
Removable items (Absent in design, present in prod notification menu)
Add MenuItem Component
Color variants + align variants
Disabled, Danger color variant
