replaced userAvatar throughout the project #2975
Open
+23
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markgol777
requested review from
amoutens,
PavloButynets,
ShadowOfTheSpace,
Made1ra,
ArtemHolikov,
luiqor and
OFrankov
and removed request for
amoutens
ShadowOfTheSpace
requested changes
Dec 17, 2024
Comment on lines
+32
to
+33
| firstName = '', | ||
| lastName = '', |
There was a problem hiding this comment.
If you add default value to those props, make them optional in BaseUserAvatarProps
markgol777
force-pushed
the
feature/2947/replace-userAvatar
branch
from
93d28c1 to
05d64ab
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced it through out the whole project, fixed the tests and modified the component.