Fix sonar issues in pages, containers, components folders #2968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandrvvu
changed the title
sandrvvu
requested review from
ShadowOfTheSpace,
Mav-Ivan,
amoutens,
nebby2105 and
VKormylo
amoutens
approved these changes
Dec 12, 2024
ShadowOfTheSpace
requested changes
Dec 12, 2024
src/containers/find-offer/offer-filter-block/offer-filter-list/OfferFilterList.tsx
Outdated
Show resolved
Hide resolved
src/containers/my-cooperations/my-cooperations-details/MyCooperationsDetails.tsx
Show resolved
Hide resolved
|
Made1ra
approved these changes
Dec 16, 2024
| @@ -60,12 +60,14 @@ const OfferFilterList: FC<OfferFilterListProps> = ({ | |||
| const handleFilterChange = (key: keyof FindOffersFilters) => () => | |||
| updateFilterByKey(key) | |||
|
|
|||
| const getOptionLabelForLanguage = (option: LanguageFilter | null): string => { | |||
There was a problem hiding this comment.
Suggested change
| const getOptionLabelForLanguage = (option: LanguageFilter | null): string => { | |
| const getOptionLabelForLanguage = (option: LanguageFilter | null) => { |
Is a return type here necessary?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed some sonar issues in pages, containers, components folder.