Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

incorrect description of Badge maxContent prop in storybook #2965

Merged
merged 1 commit into from
Dec 12, 2024
Merged

incorrect description of Badge maxContent prop in storybook #2965

merged 1 commit into from
Dec 12, 2024

Conversation

nebby2105
Copy link
Contributor

@nebby2105 nebby2105 commented Dec 11, 2024 •
edited
Loading

#2938
before
Screenshot 2024-12-11 at 20 25 20

after
Screenshot 2024-12-11 at 20 24 47

  • fixed incorrect description of Badge maxContent prop in storybook

@nebby2105 nebby2105 added bug Something isn't working design system task related to scss design system labels Dec 11, 2024
@nebby2105 nebby2105 self-assigned this Dec 11, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Made1ra Made1ra linked an issue Dec 12, 2024 that may be closed by this pull request
Fix incorrect Badge description in storybook #2938
Closed
@nebby2105 nebby2105 merged commit 006f2fd into develop Dec 12, 2024
10 checks passed
@nebby2105 nebby2105 deleted the bugfix/2938/incorrect-badge-description branch December 12, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amoutens amoutens amoutens approved these changes

@Made1ra Made1ra Made1ra approved these changes

@ShadowOfTheSpace ShadowOfTheSpace ShadowOfTheSpace approved these changes

@dudchakk dudchakk dudchakk approved these changes

@luiqor luiqor Awaiting requested review from luiqor

Assignees

@nebby2105 nebby2105

Labels
bug Something isn't working design system task related to scss design system
Projects
SpaceToStudy
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix incorrect Badge description in storybook
5 participants
@nebby2105 @dudchakk @ShadowOfTheSpace @Made1ra @amoutens