The user can not save the information on 'Edit Profile' page after clicking on the 'Home page' #2937
Conversation
ArtemHolikov
force-pushed
the
bugfix/2805/user-cannot-save-info
branch
from
186c8d3 to
2c875f2
Compare
ArtemHolikov
requested review from
dudchakk,
Made1ra,
Mav-Ivan,
amoutens,
Mike-Popovych,
luiqor and
SofiiaYevush
|
| if (hasChanged) { | ||
| const changes: Partial<EditProfileState> = { | ||
| ...changedCurrent | ||
| } | ||
|
|
||
| if (!hasChanges(changedInitial.videoLink, changedCurrent.videoLink)) { | ||
| delete changes.videoLink | ||
| } | ||
|
|
||
| if (hasPhotoChanged) { | ||
| changes.photo = changedCurrent.photo | ||
| } | ||
|
|
||
| return changes | ||
| } else { | ||
| return {} | ||
| } |
There was a problem hiding this comment.
Try to replace this block with if-not approach. You will not have an exta else here.
| @@ -103,6 +104,63 @@ const EditProfile = () => { | |||
| } | |||
| }, [loading, profileState, initialEditProfileState]) | |||
|
|
|||
| const changedProfileFields = useMemo<Partial<EditProfileState>>(() => { | |||
| if (!initialEditProfileState || !profileState) return {} | |||
There was a problem hiding this comment.
I would recommend you to not return {} for non-changed profile fields. It's not obvious actualy.
Return null if profile fields are not changed, it will simplify logic for isProfileChanged variable calculation. You will have just const isProfileChanged = Boolean(changedProfileFields) without useMemo
| @@ -213,7 +271,41 @@ const EditProfile = () => { | |||
| if (hash) { | |||
| navigate(`${authRoutes.myProfile.path}#complete`) | |||
| } | |||
| } | |||
| }, [profileState, changedFields]) | |||
There was a problem hiding this comment.
Fix linter errors here. This function can have unexpectable behaviour because of missing dependencies
| const changedProfileFields = useMemo<Partial<EditProfileState>>(() => { | ||
| if (!initialEditProfileState || !profileState) return {} | ||
|
|
||
| const changedInitial = { |
There was a problem hiding this comment.
Rename it, please.
| const changedInitial = { | |
| const initialProfileInformation = { |
| videoLink: initialEditProfileState.videoLink | ||
| } | ||
|
|
||
| const changedCurrent = { |
There was a problem hiding this comment.
| const changedCurrent = { | |
| const changedProfileInformation = { |
| videoLink: profileState.videoLink | ||
| } | ||
|
|
||
| const hasPhotoChanged = hasPhotoChanges( |
There was a problem hiding this comment.
| const hasPhotoChanged = hasPhotoChanges( | |
| const isPhotoChanged = hasPhotoChanges( |
| changedCurrent.photo | ||
| ) | ||
|
|
||
| const hasChanged = |
There was a problem hiding this comment.
| const hasChanged = | |
| const isProfileInformationChanged = |
Was result:
If user has unsaved changes and redirected to another page, he could do this without any information about unsaved changes.
Actual result:
If user has unsaved changes and want to go to another page, modal window appears about unsaved changes with propose to update or leave without changes.
Space2Study.-.Google.Chrome.2024-12-05.13-55-23.mp4