Fixed invalid additionalInfo validation in enroll offer modal #2918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VKormylo
requested review from
dudchakk,
ShadowOfTheSpace,
markgol777,
Made1ra,
Mav-Ivan and
luiqor
markgol777
approved these changes
Dec 1, 2024
markgol777
requested changes
Dec 1, 2024
markgol777
approved these changes
Dec 3, 2024
luiqor
reviewed
Dec 3, 2024
There was a problem hiding this comment.
Additional info cannot be empty "" (0 characters), as it causes a server error. It must either be not included to request or contain more than 30 characters. Please update the logic to ensure that additionalInfo is not sent if the input field is empty string.
|
Fixed incorrect empty additionalInfo in request |
|
luiqor
approved these changes
Dec 3, 2024
SofiiaYevush
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added validation for additional info to be at least 30 symbols or empty in enroll offer modal.
Validation looks like this.
If the field is empty, there is no validation.