-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement review submission logic by creating AddReviewModal.tsx #2915
Open
dudchakk
wants to merge
7
commits into
develop
Choose a base branch
from
feature/2910/review-modal
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dudchakk
added
Frontend part
feature
design
Task for designers
Tutor
Implementation that regard to the tutor
Student
Implementation that regard to the student
Functional
Something isn't working
labels
Nov 30, 2024
Quality Gate failedFailed conditions |
dudchakk
changed the title
Implement AddReviewModal
Implement review submission logic by creating AddReviewModal.tsx
Dec 4, 2024
ShadowOfTheSpace
requested changes
Dec 11, 2024
src/containers/my-cooperations/add-review-modal/AddReviewModal.constants.ts
Outdated
Show resolved
Hide resolved
src/containers/my-cooperations/add-review-modal/AddReviewModal.styles.ts
Outdated
Show resolved
Hide resolved
src/containers/my-cooperations/add-review-modal/AddReviewModal.tsx
Outdated
Show resolved
Hide resolved
src/containers/my-cooperations/add-review-modal/AddReviewModal.tsx
Outdated
Show resolved
Hide resolved
src/containers/my-cooperations/cooperation-completion/CooperationCompletion.tsx
Outdated
Show resolved
Hide resolved
src/containers/my-cooperations/cooperation-completion/CooperationCompletion.tsx
Show resolved
Hide resolved
ShadowOfTheSpace
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
design
Task for designers
feature
Frontend part
Functional
Something isn't working
Student
Implementation that regard to the student
Tutor
Implementation that regard to the tutor
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: This PR implements the design and functionality of the
Add review modal
, allowing users to leave feedback after a collaboration.!! Important: For testing purposes, for now the modal opens when clicking on the
Close cooperation
button. After the functional will be finished, the modal will open after the user confirmes that he wants to close the cooperation.UI part:
How it looks:
Logic part:
Required fields for a review on backend:
ReviewService
&&submitReview
function to send review data according to backend requirements`;CooperationDetails
(information about the target user & offer) and input data inAddReviewModal
(comment & rating);useAxios
hook to handle API communication, handle errors and give feedback for the user, indicating the success or failure of the submission;useForm
hook to manage the modal’s form state including input values, validation and submission logic.How it works:
Recording.submit-review.mp4