(SP:5) Create Chip component #2901
Conversation
sandrvvu
added
Frontend part
feature
test
design system
sandrvvu
requested review from
ShadowOfTheSpace,
VKormylo,
Mav-Ivan,
PavloButynets,
Mike-Popovych,
luiqor and
nebby2105
sandrvvu
force-pushed
the
feature/2843/create-chip-component
branch
from
9c1d737 to
d982443
Compare
|
check Sonar issues |
sandrvvu
force-pushed
the
feature/2843/create-chip-component
branch
from
1866d31 to
b981e4c
Compare
Some issues are weird, most likely due to If they stay after merging - I will make a new bug and fix it already there |
| const [isOpen, setIsOpen] = useState(false) | ||
| const [selectedOption, setSelectedOption] = useState<string | null>(null) | ||
|
|
||
| const handleSelect = (option: string) => { | ||
| setSelectedOption(option) | ||
| setIsOpen((prev) => !prev) |
There was a problem hiding this comment.
All basic components must be stateless and all logic must be implemented at the level of the parent component (the value and the function to change this value must be passed through props). Here the component is quite limited because handleSelect only changes the behavior of the component itself, but this function can perform more difficult logic (for example, API request, interaction with other components or states, etc.). That is why the component should not have its own state and any other logic,
because now the only thing it can do is simply change the states of isOpen and selectedOption and make the appropriate style changes
|
Examples of chips:
About types and props:
Added info to StoryBook
Added tests