Create a UserAvatar component #2898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… write tests for it
PavloButynets
added
Frontend part
feature
component
design system
PavloButynets
requested review from
Mav-Ivan,
dudchakk,
Made1ra,
amoutens and
Renatavl
amoutens
requested changes
Nov 27, 2024
There was a problem hiding this comment.
please fix Sonar Issue and add more coverage on tests
amoutens
requested changes
Dec 3, 2024
| /> | ||
| ) : variant === 'monogram' ? ( | ||
| <MuiAvatar | ||
| onClick={onClick} |
There was a problem hiding this comment.
you can replace cn('s2s-avatar', s2s-avatar-${size}) to variable
| )} | ||
| {isOnline && ( | ||
| <span | ||
| className={`s2s-user-avatar-status s2s-user-avatar-status-${size}`} |
|
amoutens
approved these changes
Dec 4, 2024
Made1ra
reviewed
Dec 4, 2024
RomanRozbytskyi
approved these changes
Dec 4, 2024
SofiiaYevush
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a reusable UserAvatar component that meets the design system standards. Covered the tests component and added to the storybook
