Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace AppButton for Button #2881

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Replace AppButton for Button #2881

wants to merge 4 commits into from

Conversation

Mav-Ivan
Copy link
Contributor

  • Replaced AppButton for Button all over the project.
  • Fixed tests

@Mav-Ivan Mav-Ivan added Frontend part feature design system task related to scss design system labels Nov 25, 2024
@Mav-Ivan Mav-Ivan self-assigned this Nov 25, 2024
@Mav-Ivan Mav-Ivan linked an issue Nov 26, 2024 that may be closed by this pull request
(SP: 2) Replace the old AppButton with a new one all over the project #2645
Open
dudchakk
dudchakk requested changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@dudchakk dudchakk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

impressive work, but please fix the small bugs)

src/containers/change-resource-confirm-modal/ChangeResourceConfirmModal.tsx Show resolved Hide resolved
src/containers/edit-profile/profile-tab/profile-tab-form/ProfileTabForm.tsx Show resolved Hide resolved
src/design-system/scss/_variables.scss Outdated Show resolved Hide resolved
src/pages/create-or-edit-lesson/CreateOrEditLesson.tsx Show resolved Hide resolved
src/router/constants/authRoutes.ts Show resolved Hide resolved
@Mav-Ivan Mav-Ivan force-pushed the feature/2645/replace-AppButton-for-Button branch from 0bd527c to 6377b06 Compare November 28, 2024 10:29
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
97.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Mav-Ivan Mav-Ivan requested a review from dudchakk November 28, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mike-Popovych Mike-Popovych Mike-Popovych approved these changes

@markgol777 markgol777 markgol777 approved these changes

@dudchakk dudchakk dudchakk approved these changes

@Renatavl Renatavl Awaiting requested review from Renatavl

@ArtemHolikov ArtemHolikov Awaiting requested review from ArtemHolikov

@luiqor luiqor Awaiting requested review from luiqor

Assignees

@Mav-Ivan Mav-Ivan

Labels
design system task related to scss design system feature Frontend part
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(SP: 2) Replace the old AppButton with a new one all over the project
4 participants
@Mav-Ivan @dudchakk @markgol777 @Mike-Popovych