changed the way and places where study material access is displayed #2839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
markgol777
commented
Nov 21, 2024
markgol777
commented
markgol777
requested review from
ArtemHolikov,
ipasic-softserve,
Mav-Ivan,
Mike-Popovych and
Renatavl
src/containers/my-cooperations/cooperation-completion/CooperationCompletion.tsx
Show resolved
Hide resolved
ShadowOfTheSpace
approved these changes
Nov 21, 2024
|
Renatavl
reviewed
Nov 21, 2024
| @@ -51,6 +53,8 @@ const TeachingBlock = <T extends CreateOrUpdateOfferData>({ | |||
| } | |||
| } | |||
|
|
|||
| const studyMaterials = userRole === UserRoleEnum.Student && <StudyMaterials /> | |||
There was a problem hiding this comment.
May be it is better not to create a variable but just move userRole === UserRoleEnum.Student && <StudyMaterials /> to 140 line and put it in brackets instead of studyMaterials. It is not necessary, it's up to you
Renatavl
approved these changes
Nov 21, 2024
ArtemHolikov
approved these changes
Nov 25, 2024
Made1ra
pushed a commit
that referenced
this pull request
Nov 26, 2024
…2839) * changed the way and places where study material access is displayed * removed comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.