Create CheckBox component aligned with design system #2838
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixed header * fixed styles
* new test implementation of AppButton component * updated props * changed structures for design system * fixed import * implemented story for Button * excluded stories from tests and sonar --------- Co-authored-by: YaroslavChuiko <[email protected]>
* fix: add use memo missing dependencies * fix: prevent accordion desc text overflow
nebby2105
added
Frontend part
feature
design system
nebby2105
requested review from
dudchakk,
ipasic-softserve,
VKormylo,
Mav-Ivan and
amoutens
|
|
|
||
| type Ref = MuiButtonProps['ref'] | ||
|
|
||
| const Button = forwardRef( |
There was a problem hiding this comment.
Add generic types to forwardRef function. So you will not have to type Ref manually. Also props at 40-48 lines will be typed as well.
| onChange={handleChange} | ||
| /> | ||
| )} | ||
|
|
| size = 'md', | ||
| ...props | ||
| }) => { | ||
| const [checked, setChecked] = useState(false) |
There was a problem hiding this comment.
Add generic here.
It is a good practice to have generic type in useState hook, even if it has default value
|
add new pr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2702
Created Checkbox component with the following configurable props:
Default Parameters:
Color: primary
Variant: check
Size: md
Label Position: end
Loading: false
Disabled: false
Default parameters:
Color="success"
Color="error"
labelPosition="top"
labelPosition="bottom"
