Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added reusable Switch Component according to design systems #2834

Conversation

amoutens
Copy link
Contributor

@amoutens amoutens commented Nov 21, 2024

Added switch aligned with design systems

Added optional props that include:
label
labelPosition
size
loading
disabled

default:
image

checked:
image

hover:
image

image

loading and disabled:
image

label and label positions:
image
image
image
image

sizes change (medium by default):
Large:
image
Small:
image

Have some problems with disabled hover, please contact my tg @amoutens

@amoutens amoutens added component Frontend part feature design system task related to scss design system labels Nov 21, 2024
@amoutens amoutens self-assigned this Nov 21, 2024
@amoutens amoutens linked an issue Nov 21, 2024 that may be closed by this pull request
@amoutens amoutens changed the title Added reuseable Switch Component according to design systems Added reusable Switch Component according to design systems Nov 21, 2024
@amoutens amoutens marked this pull request as draft November 21, 2024 14:29
@amoutens amoutens marked this pull request as ready for review November 22, 2024 11:11
@nebby2105
Copy link
Contributor

It might be better to move the AppSwitch component to the design-system folder, along with its styles and stories

@amoutens amoutens requested review from markgol777, Made1ra and luiqor and removed request for ipasic-softserve November 25, 2024 09:33
Copy link
Contributor

@Mav-Ivan Mav-Ivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move component to src/design-system/components
move stories to src/design-system/stories
move test to tests/unit/design-system
Also use aliases ~scss-components , ~scss

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants