Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created reusable link button component #2818

Merged
merged 5 commits into from
Dec 3, 2024
Merged

Created reusable link button component #2818

merged 5 commits into from
Dec 3, 2024

Conversation

VKormylo
Copy link
Contributor

Created reusable link button component for good consistency in website links.
Screenshot from storybook
image

@VKormylo VKormylo self-assigned this Nov 20, 2024
@VKormylo VKormylo linked an issue Nov 20, 2024 that may be closed by this pull request
(SP: 3) Create LinkButton component aligned with design system #2700
Closed
@VKormylo VKormylo added Frontend part component design system task related to scss design system labels Nov 20, 2024
@VKormylo VKormylo requested review from ShadowOfTheSpace and removed request for PavloDolia November 21, 2024 21:39
Mav-Ivan
Mav-Ivan requested changes Nov 26, 2024
View reviewed changes
Copy link
Contributor

@Mav-Ivan Mav-Ivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move component to src/design-system/components
move stories to src/design-system/stories
move test to tests/unit/design-system
Also use aliases ~scss-components , ~scss

@VKormylo
Copy link
Contributor Author

Ok, I'm going to fix that.

@VKormylo VKormylo requested a review from Mav-Ivan November 26, 2024 20:42
@VKormylo VKormylo requested review from PavloButynets, Made1ra and nebby2105 and removed request for ipasic-softserve November 28, 2024 21:52
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@VKormylo VKormylo merged commit c91b121 into develop Dec 3, 2024
10 checks passed
@VKormylo VKormylo deleted the feature/2700/create-link-button-component branch December 3, 2024 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mav-Ivan Mav-Ivan Mav-Ivan approved these changes

@markgol777 markgol777 markgol777 approved these changes

@ShadowOfTheSpace ShadowOfTheSpace ShadowOfTheSpace approved these changes

@dudchakk dudchakk Awaiting requested review from dudchakk

@Renatavl Renatavl Awaiting requested review from Renatavl

@Mike-Popovych Mike-Popovych Awaiting requested review from Mike-Popovych

@PavloButynets PavloButynets Awaiting requested review from PavloButynets

@Made1ra Made1ra Awaiting requested review from Made1ra

@nebby2105 nebby2105 Awaiting requested review from nebby2105

Assignees

@VKormylo VKormylo

Labels
component design system task related to scss design system Frontend part
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(SP: 3) Create LinkButton component aligned with design system
4 participants
@VKormylo @ShadowOfTheSpace @markgol777 @Mav-Ivan