Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed popup size #2813

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/constants/translations/en/common.json
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
"level": "Level:"
},
"errorMessages": {
"emailValid": "Email should be of the following format: “local-part@domain.com”",
"emailValid": "Email should follow format: “email@domain.com”",
"passwordLength": "Password cannot be shorter than 8 and longer than 25 characters",
"passwordAlphabeticAndNumeric": "Password must contain at least one alphabetic and one numeric character",
"passwordValidSymbols": "Password must contain only alphabetic, numeric and special characters",
Expand Down
2 changes: 1 addition & 1 deletion src/constants/translations/uk/common.json
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@
"level": "Рівень:"
},
"errorMessages": {
"emailValid": "Електронна пошта має бути такого формату: “local-part@domain.com”",
"emailValid": "Формат ел.пошти: “email@domain.com”",
"passwordLength": "Пароль не може бути коротшим за 8 і довшим за 25 символів",
"passwordAlphabeticAndNumeric": "Пароль повинен містити принаймні одну літеру та одну цифру",
"passwordValidSymbols": "Пароль повинен містити лише букви, цифри та спеціальні символи",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ const style = {
formContainer: {
display: 'flex',
flexDirection: 'column',
maxHeight: 'inherit',
height: '551px',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it look correct on other devices, for example mobile phones, with this hardcoded value?

boxSizing: 'border-box',
borderTop: { xs: '1px solid', sm: 'none' },
borderColor: { xs: 'primary.100' },
Expand All @@ -41,7 +41,6 @@ const style = {
overflow: 'auto',
pt: '16px',
pr: { xs: '8px', sm: '96px', md: '80px', lg: '96px' },
pb: { xs: '24px', sm: '64px' },
...scrollbar
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ export const styles = {
form: {
display: 'flex',
flexDirection: 'column',
minWidth: { sm: '340px' }
width: { sm: '340px' }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why did you hardcoded the width property?

},
loginOptionsContainer: {
display: 'flex',
Expand Down
Loading