Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix long names spilling outside container on profile page #2809

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Fix long names spilling outside container on profile page #2809

merged 1 commit into from
Nov 22, 2024

Conversation

luiqor
Copy link
Contributor

@luiqor luiqor commented Nov 20, 2024

Fix long first and last names being covered by 'Edit profile' button and extend outside the container on the profile page

Demo with the longest possible name and surname (30 characters each):

Desktop:
image

Mobile:
image-1

@luiqor luiqor added bug Something isn't working Tutor Implementation that regard to the tutor Student Implementation that regard to the student UI/Usability my-profile labels Nov 20, 2024
@luiqor luiqor self-assigned this Nov 20, 2024
@luiqor luiqor linked an issue Nov 20, 2024 that may be closed by this pull request
Long first and last names are covered by 'Edit profile' button and extend outside the container on the profile page. #2725
Closed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@luiqor luiqor merged commit ceaa991 into develop Nov 22, 2024
9 checks passed
@luiqor luiqor deleted the bugfix/2725/long-full-name-extend-outside branch November 22, 2024 16:08
Made1ra pushed a commit that referenced this pull request Nov 26, 2024
@luiqor @Made1ra
fix long names spilling outside container on profile page (#2809)
c7ea4fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mav-Ivan Mav-Ivan Mav-Ivan approved these changes

@Renatavl Renatavl Renatavl approved these changes

@ipasic-softserve ipasic-softserve ipasic-softserve approved these changes

@dudchakk dudchakk Awaiting requested review from dudchakk

@Mike-Popovych Mike-Popovych Awaiting requested review from Mike-Popovych

Assignees

@luiqor luiqor

Labels
bug Something isn't working my-profile Student Implementation that regard to the student Tutor Implementation that regard to the tutor UI/Usability
Projects
None yet
Milestone
No milestone
4 participants
@luiqor @ipasic-softserve @Renatavl @Mav-Ivan