Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unintended horizontal scrolling issue on opening cooperation details #2786

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

luiqor
Copy link
Contributor

@luiqor luiqor commented Nov 19, 2024

Fix the issue where the "About Cooperation" or "Cooperation Title" text is too long, causing unintended horizontal scrolling when opening "Cooperation Notes".

2696.mp4

@luiqor luiqor added bug Something isn't working Frontend part UI/Usability labels Nov 19, 2024
@luiqor luiqor self-assigned this Nov 19, 2024
Copy link
Contributor

@markgol777 markgol777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"React Hook useMemo has missing dependencies: 'itemKeys' and 'userRole'. Either include them or remove the dependency array"

It's a Lint issue which also appears locally while running tests, could you please fix it?

@ShadowOfTheSpace
Copy link
Contributor

"React Hook useMemo has missing dependencies: 'itemKeys' and 'userRole'. Either include them or remove the dependency array"

It's a Lint issue which also appears locally while running tests, could you please fix it?

I am not sure, that this eslint warning is relative to her PR. Probably it needs to be separated into new task or fixed when PR is relative to the UserProfile page.

@luiqor
Copy link
Contributor Author

luiqor commented Nov 19, 2024

"React Hook useMemo has missing dependencies: 'itemKeys' and 'userRole'. Either include them or remove the dependency array"

It's a Lint issue which also appears locally while running tests, could you please fix it?

This issue is unrelated to the current task. The error appears as Unchanged files with check annotations in all recent PR`s file changes. So it should be addressed as part of a separate task.

@luiqor luiqor requested a review from markgol777 November 19, 2024 16:25
@luiqor luiqor merged commit 52eb427 into develop Nov 22, 2024
9 checks passed
@luiqor luiqor deleted the bugfix/2696/unintended-cooperation-notes-scrolling branch November 22, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(SP: ) Fix unintended horizontal scrolling when Cooperation Notes are opened
5 participants