Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrote EnumFilter jsx to tsx and sonarfix #2754

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Rewrote EnumFilter jsx to tsx and sonarfix #2754

merged 3 commits into from
Nov 26, 2024

Conversation

SofiiaYevush
Copy link
Contributor

@SofiiaYevush SofiiaYevush commented Nov 17, 2024 •
edited
Loading

Rewrote EnumFilter.jsx to EnumFilter.tsx and fixed sonar issues #2094

image

image

@SofiiaYevush SofiiaYevush added bug Something isn't working good first issue Good for newcomers TypeScript Convert to TS sonarFix fix the sonar issues labels Nov 17, 2024
@SofiiaYevush SofiiaYevush self-assigned this Nov 17, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@SofiiaYevush SofiiaYevush merged commit 1b4c8cb into develop Nov 26, 2024
9 checks passed
@SofiiaYevush SofiiaYevush deleted the bugfix/2094/rewrite-enumfilter-jsx-to-tsx branch November 26, 2024 21:23
@SofiiaYevush SofiiaYevush linked an issue Nov 26, 2024 that may be closed by this pull request
(SP: 1) Rewrite EnumFilter to tsx format and fix the sonar issues #2094
Closed
Made1ra pushed a commit that referenced this pull request Nov 28, 2024
@SofiiaYevush @Made1ra
Rewrote EnumFilter jsx to tsx and sonarfix (#2754)
b5d35d8 
* Rewrote EnumFilter jsx to tsx

* Extracted filter.length into a variable

* Extracted comparison in a variable isFilterEmpty
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mav-Ivan Mav-Ivan Mav-Ivan approved these changes

@ShadowOfTheSpace ShadowOfTheSpace ShadowOfTheSpace approved these changes

@ipasic-softserve ipasic-softserve ipasic-softserve approved these changes

@dudchakk dudchakk dudchakk approved these changes

Assignees

@SofiiaYevush SofiiaYevush

Labels
bug Something isn't working good first issue Good for newcomers sonarFix fix the sonar issues TypeScript Convert to TS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(SP: 1) Rewrite EnumFilter to tsx format and fix the sonar issues
5 participants
@SofiiaYevush @dudchakk @ipasic-softserve @ShadowOfTheSpace @Mav-Ivan