converted ResetPassword component from jsx to tsx #2688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markgol777
added
good first issue
markgol777
requested review from
Mav-Ivan,
ipasic-softserve,
Renatavl,
PavloDolia and
Mike-Popovych
Renatavl
requested changes
Nov 13, 2024
| onSubmit: () => sendResetPassword({ password: data.password }), | ||
| const { handleSubmit, handleInputChange, handleBlur, errors, data } = | ||
| useForm<NewPassword>({ | ||
| onSubmit: (): Promise<void> => |
There was a problem hiding this comment.
Maybe it is better to write it like onSubmit: async () => because in that way it would be clearer for other developers that this is an asynchronous function
|
ipasic-softserve
approved these changes
Nov 14, 2024
Mav-Ivan
approved these changes
Nov 15, 2024
Renatavl
approved these changes
Nov 19, 2024
Made1ra
pushed a commit
that referenced
this pull request
Nov 26, 2024
* converted ResetPassword component from jsx to tsx * added async for clarity of the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.