Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the height of card when 1 bookmark selected #2687

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

VKormylo
Copy link
Contributor

Fixed the height of card when 1 bookmark selected
Now it looks like this
image

@VKormylo VKormylo added bug Something isn't working good first issue Good for newcomers Frontend part labels Nov 12, 2024
@VKormylo VKormylo self-assigned this Nov 12, 2024
@VKormylo VKormylo linked an issue Nov 12, 2024 that may be closed by this pull request
Copy link
Contributor

@ipasic-softserve ipasic-softserve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When on grid view, the gap is still present:

image

@VKormylo
Copy link
Contributor Author

Is it okay like this now?
Gap in the first one is slightly bigger because it has less lines in title than others
image

@Renatavl
Copy link
Contributor

image

@VKormylo PR is related to fixing the height of card but there are a lot of files added which do not relate to this issue

@VKormylo
Copy link
Contributor Author

VKormylo commented Nov 14, 2024

Other person's commit accidentally got added to the branch, I'm going to fix that.

@VKormylo VKormylo force-pushed the bugfix/2661/fix-card-height branch from 796dc7f to 3e64d86 Compare November 14, 2024 08:50
@VKormylo VKormylo force-pushed the bugfix/2661/fix-card-height branch from 3e64d86 to c94bb4c Compare November 15, 2024 19:56
@VKormylo VKormylo requested a review from Mav-Ivan November 15, 2024 19:59
@VKormylo VKormylo merged commit f04ea6c into develop Nov 21, 2024
9 checks passed
@VKormylo VKormylo deleted the bugfix/2661/fix-card-height branch November 21, 2024 17:10
Made1ra pushed a commit that referenced this pull request Nov 26, 2024
* Fixed the height of card when 1 bookmark selected

* Fixed gap when on grid view

* Refactored CSS
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Frontend part good first issue Good for newcomers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(SP: 0.5) Fix card height
4 participants