Fixed using array index as key in lists #2685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Made1ra
added
good first issue
Made1ra
requested review from
Mav-Ivan,
ipasic-softserve,
Renatavl,
PavloDolia,
Mike-Popovych and
dudchakk
| @@ -214,7 +214,7 @@ const AddProfessionalCategoryModal: FC<AddProfessionalCategoryModalProps> = ({ | |||
| disableOptions={data.subjects as Array<Partial<SubjectInterface>>} | |||
| handleChange={handleProfessionalSubjectChange(index)} | |||
| handleSubjectDelete={() => handleSubjectDelete(subject._id || '')} | |||
| key={index} | |||
| key={subject._id || crypto.randomUUID()} | |||
There was a problem hiding this comment.
Is there any chance for _id here to be falsable?
There was a problem hiding this comment.
Yes, sometimes it's just an empty string.
There was a problem hiding this comment.
I think we can remove crypto.randomUUID(), since id='' will only be used once, when no category has been selected yet.
ipasic-softserve
approved these changes
Nov 13, 2024
| @@ -214,7 +214,7 @@ const AddProfessionalCategoryModal: FC<AddProfessionalCategoryModalProps> = ({ | |||
| disableOptions={data.subjects as Array<Partial<SubjectInterface>>} | |||
| handleChange={handleProfessionalSubjectChange(index)} | |||
| handleSubjectDelete={() => handleSubjectDelete(subject._id || '')} | |||
| key={index} | |||
| key={subject._id || crypto.randomUUID()} | |||
There was a problem hiding this comment.
I think we can remove crypto.randomUUID(), since id='' will only be used once, when no category has been selected yet.
|
Renatavl
approved these changes
Nov 13, 2024
Mike-Popovych
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Using array indices as keys in list components can cause unexpected behavior, especially when items are reordered or changed. Instead, use a unique ID for each item to help React handle updates more efficiently.
File Affected:
AddProfessionalCategoryModal.tsx