Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the bookmarked offers page #2652

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Fixed the bookmarked offers page #2652

merged 2 commits into from
Nov 12, 2024

Conversation

PavloDolia
Copy link
Contributor

@PavloDolia PavloDolia commented Oct 28, 2024 •
edited
Loading

  • fixed the text input;
  • added smooth scrolling to the top when the page number is changed

@PavloDolia PavloDolia added bug Something isn't working Frontend part labels Oct 28, 2024
@PavloDolia PavloDolia self-assigned this Oct 28, 2024
@PavloDolia PavloDolia linked an issue Oct 28, 2024 that may be closed by this pull request
(SP: 0.5) Fix bookmarked offers page #2651
Closed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
90.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

PavloDolia
PavloDolia commented Oct 28, 2024
View reviewed changes
src/containers/bookmarked-offers/BookmarksToolbar.tsx
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added forwardRef in the line 29, handleInputChange in the line 38 and BookmarksToolbar.displayName in the line 103. Everything else remains unchanged

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn’t quite understand your comment. Why the other lines are changed then?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this comment to clarify what really was changed in this file. All other lines are changed because forwardRef was added and indentations are changed

@PavloDolia PavloDolia merged commit dd0388e into develop Nov 12, 2024
9 checks passed
@PavloDolia PavloDolia deleted the bugfix/2651/fix-bookmarked-offers-page branch November 12, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mike-Popovych Mike-Popovych Mike-Popovych approved these changes

@ipasic-softserve ipasic-softserve ipasic-softserve approved these changes

@dudchakk dudchakk dudchakk approved these changes

@Renatavl Renatavl Awaiting requested review from Renatavl

@Mav-Ivan Mav-Ivan Awaiting requested review from Mav-Ivan

Assignees

@PavloDolia PavloDolia

Labels
bug Something isn't working Frontend part
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(SP: 0.5) Fix bookmarked offers page
4 participants
@PavloDolia @dudchakk @ipasic-softserve @Mike-Popovych