Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add snackbar after creating an offer in CompleteProfileBlock #2635

Merged
merged 17 commits into from
Dec 4, 2024
Merged

Add snackbar after creating an offer in CompleteProfileBlock #2635

merged 17 commits into from
Dec 4, 2024

Conversation

dudchakk
Copy link
Contributor

How it works now:

Recording-snackbar-after-request.mp4

Also, added conditional text for tutor/student and ukrainian translation.

@dudchakk dudchakk self-assigned this Oct 23, 2024
@dudchakk dudchakk linked an issue Nov 28, 2024 that may be closed by this pull request
(SP: 2) Add a popup with redirect to 'My offers' after creating an offer/request in CompleteProfileBlock #2591
Closed
@Made1ra Made1ra self-assigned this Nov 29, 2024
@Made1ra Made1ra linked an issue Nov 29, 2024 that may be closed by this pull request
(SP: 2) Write test for onResponse & onError in CreateOrEditOffer.tsx #2909
Open
@Made1ra Made1ra removed a link to an issue Dec 3, 2024
(SP: 2) Write test for onResponse & onError in CreateOrEditOffer.tsx #2909
Open
@Made1ra Made1ra assigned Made1ra and unassigned dudchakk and Made1ra Dec 3, 2024
@Made1ra Made1ra assigned dudchakk and unassigned Made1ra Dec 3, 2024
ShadowOfTheSpace
ShadowOfTheSpace requested changes Dec 3, 2024
View reviewed changes
src/containers/layout/app-snackbar/AppSnackbar.tsx Outdated Show resolved Hide resolved
src/containers/layout/app-snackbar/AppSnackbar.tsx Outdated Show resolved Hide resolved
src/containers/layout/app-snackbar/AppSnackbar.tsx Outdated Show resolved Hide resolved
src/containers/offer-page/create-or-edit-offer/CreateOrEditOffer.tsx Outdated Show resolved Hide resolved
src/redux/features/snackbarSlice.ts Outdated Show resolved Hide resolved
src/types/offer/interfaces/offer.interfaces.ts Outdated Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
66.7% Coverage on New Code (required ≥ 80%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@dudchakk dudchakk merged commit 0999032 into develop Dec 4, 2024
9 of 10 checks passed
@dudchakk dudchakk deleted the feature/2591/popup-with-my-offers branch December 4, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amoutens amoutens amoutens approved these changes

@Made1ra Made1ra Made1ra approved these changes

@ShadowOfTheSpace ShadowOfTheSpace ShadowOfTheSpace approved these changes

@markgol777 markgol777 Awaiting requested review from markgol777

@Renatavl Renatavl Awaiting requested review from Renatavl

@ArtemHolikov ArtemHolikov Awaiting requested review from ArtemHolikov

@SofiiaYevush SofiiaYevush Awaiting requested review from SofiiaYevush

Assignees

@dudchakk dudchakk

Labels
feature Frontend part
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(SP: 2) Add a popup with redirect to 'My offers' after creating an offer/request in CompleteProfileBlock
4 participants
@dudchakk @ShadowOfTheSpace @Made1ra @amoutens