Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhanced chat search #2628

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Enhanced chat search #2628

wants to merge 5 commits into from
+127 −25

Conversation

Mav-Ivan
Copy link
Contributor

2024-10-16.21-12-19.mp4

@Mav-Ivan Mav-Ivan added enhancement New feature or request Frontend part labels Oct 17, 2024
@Mav-Ivan Mav-Ivan self-assigned this Oct 17, 2024
@Mav-Ivan Mav-Ivan linked an issue Oct 17, 2024 that may be closed by this pull request
(SP: 2) Enhance chat search #2610
Open
@Mav-Ivan Mav-Ivan marked this pull request as ready for review October 17, 2024 10:34
@Mav-Ivan Mav-Ivan force-pushed the feature/2610/enhace-chat-search branch from 16e1d47 to 48e511c Compare October 31, 2024 18:07
@Mav-Ivan Mav-Ivan requested a review from dudchakk October 31, 2024 18:08
@Mav-Ivan Mav-Ivan force-pushed the feature/2610/enhace-chat-search branch from 48e511c to 1e8f409 Compare November 11, 2024 22:24
PavloDolia
PavloDolia reviewed Nov 15, 2024
View reviewed changes
Copy link
Contributor

@PavloDolia PavloDolia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as far as I understand, searching for messages should happen on the backend, but you should ask our tech expert about it, maybe he will say this approach is alright for our app

src/containers/chat/chat-header/ChatHeader.tsx Outdated Show resolved Hide resolved
@Mav-Ivan Mav-Ivan force-pushed the feature/2610/enhace-chat-search branch from 1e8f409 to 51f25f9 Compare November 25, 2024 20:37
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
87.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Mav-Ivan Mav-Ivan requested a review from PavloDolia November 25, 2024 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mike-Popovych Mike-Popovych Mike-Popovych approved these changes

@ipasic-softserve ipasic-softserve ipasic-softserve approved these changes

@dudchakk dudchakk dudchakk approved these changes

@YaroslavChuiko YaroslavChuiko Awaiting requested review from YaroslavChuiko

@YaroslavLys YaroslavLys Awaiting requested review from YaroslavLys

@Renatavl Renatavl Awaiting requested review from Renatavl

@BohdanMylyi BohdanMylyi Awaiting requested review from BohdanMylyi

@PavloDolia PavloDolia Awaiting requested review from PavloDolia

Assignees

@Mav-Ivan Mav-Ivan

Labels
enhancement New feature or request Frontend part
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(SP: 2) Enhance chat search
5 participants
@Mav-Ivan @dudchakk @ipasic-softserve @PavloDolia @Mike-Popovych