Block with statistics by students in categories #2626
Conversation
Renatavl
commented
Oct 15, 2024
Renatavl
commented
Renatavl
added
Frontend part
feature
Tutor
Renatavl
force-pushed
the
feature/460/statistics-by-students-in-categories
branch
from
c2100cb to
6a236ca
Compare
Renatavl
requested review from
YaroslavChuiko,
ipasic-softserve,
dudchakk,
PavloDolia,
BohdanMylyi,
YaroslavLys and
Mav-Ivan
src/components/students-in-categories/StudentsInCategoriesChart.tsx
Outdated
Show resolved
Hide resolved
| ] | ||
| } | ||
|
|
||
| const options = { |
There was a problem hiding this comment.
this probably also should be relocated to consts
There was a problem hiding this comment.
This object directly belongs to component properties, but not a hardcoded value which is used as input data for the component. That's why it is better to leave it at the same place as the component
There was a problem hiding this comment.
I still don't understand what is the difference between these hardcoded values and other hardcoded values that we store in separate files with constants
| import { useTranslation } from 'react-i18next' | ||
| import { selectedCategory, years } from './StudentsInCategories.constants' | ||
|
|
||
| function StudentsInCatgories() { |
There was a problem hiding this comment.
here is a misspelling, it probably should be StudentsInCategories
| boxSizing: 'border-box', | ||
| mt: '75px' | ||
| }, | ||
|
|
There was a problem hiding this comment.
please remove the blank lines between the styles properties, as it is not the default style for our project
Renatavl
force-pushed
the
feature/460/statistics-by-students-in-categories
branch
from
650038e to
dbd4496
Compare
|
Renatavl
deleted the
feature/460/statistics-by-students-in-categories
branch
