Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use an couseCooperation service in the ChangeResourceConfirmModal #2614

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

YaroslavChuiko
Copy link
Contributor

@YaroslavChuiko YaroslavChuiko commented Oct 14, 2024

Use courseCooperation Service in ChangeResourceConfirmModal

Description

This PR integrates the courseCooperation service into the ChangeResourceConfirmModal component to enhance functionality and streamline data handling. By leveraging this service, the component can now manage cooperation-related data more efficiently, improving maintainability and aligning with existing service-based architecture.

Changes

  • Updated ChangeResourceConfirmModal: Added courseCooperation service for data handling related to course cooperation.
  • Refactored Data Fetching: Replaced direct API calls within the modal with calls to courseCooperation, reducing code redundancy.
  • Enhanced Error Handling: Improved error management through service-level error handling, ensuring cleaner code within the modal.

Testing

  • Verified that ChangeResourceConfirmModal behaves as expected with the integrated courseCooperation service.
  • Tested error handling to ensure user feedback is consistent with previous behavior.
  • Confirmed all unit tests pass.

Copy link

@YaroslavChuiko YaroslavChuiko merged commit d2f1330 into develop Oct 17, 2024
9 checks passed
@YaroslavChuiko YaroslavChuiko deleted the feature/2584/change-an-api-endpoint branch October 17, 2024 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(SP: 1) Change an api endpoint in the ChangeResourceConfirmModal container
5 participants