Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimized component re-renders caused by input change #2593

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Optimized component re-renders caused by input change #2593

merged 3 commits into from
Oct 9, 2024

Conversation

YaroslavChuiko
Copy link
Contributor

@YaroslavChuiko YaroslavChuiko commented Oct 9, 2024 •
edited
Loading

Optimized Component Re-renders Caused by Input Change

Summary

This PR addresses unnecessary component re-renders that were triggered on every input change, resulting in improved performance and a smoother user experience.

Changes

  • Enhanced input handling: Updated input change handlers to be more efficient, focusing on minimizing state updates and reducing render frequency.

@YaroslavChuiko YaroslavChuiko added bug Something isn't working Frontend part labels Oct 9, 2024
@YaroslavChuiko YaroslavChuiko self-assigned this Oct 9, 2024
@YaroslavChuiko YaroslavChuiko linked an issue Oct 9, 2024 that may be closed by this pull request
(SP: 1) Optimize re-rendering on description update #2509
Closed
PavloDolia
PavloDolia reviewed Oct 9, 2024
View reviewed changes
Copy link
Contributor

@PavloDolia PavloDolia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

when I type text into the description field, the label remains visible and overlaps the text
Screenshot 2024-10-09 at 18 06 45

@YaroslavChuiko
Copy link
Contributor Author

when I type text into the description field, the label remains visible and overlaps the text Screenshot 2024-10-09 at 18 06 45

FIxed

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Oct 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@YaroslavChuiko YaroslavChuiko merged commit 416bb33 into develop Oct 9, 2024
3 checks passed
@YaroslavChuiko YaroslavChuiko deleted the feature/2509/optimize-re-rendering-on-description-update branch October 9, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PavloDolia PavloDolia PavloDolia approved these changes

@YaroslavLys YaroslavLys YaroslavLys approved these changes

@ipasic-softserve ipasic-softserve ipasic-softserve approved these changes

@dudchakk dudchakk dudchakk approved these changes

@Renatavl Renatavl Awaiting requested review from Renatavl

@Mav-Ivan Mav-Ivan Awaiting requested review from Mav-Ivan

@Marichka0406 Marichka0406 Awaiting requested review from Marichka0406

@BohdanMylyi BohdanMylyi Awaiting requested review from BohdanMylyi

@Mike-Popovych Mike-Popovych Awaiting requested review from Mike-Popovych

Assignees

@YaroslavChuiko YaroslavChuiko

Labels
bug Something isn't working Frontend part performance optimization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(SP: 1) Optimize re-rendering on description update
5 participants
@YaroslavChuiko @dudchakk @ipasic-softserve @YaroslavLys @PavloDolia