Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Corrected pluralisation of offer counts in EN and UA Translations #2268

Closed

Conversation

YulichkaR
Copy link
Contributor

Before:
image

image

After:
image

image

YulichkaR and others added 22 commits August 1, 2024 23:36
* rewrote DateFilter to tsx

* extended DesktopDatePickerProps
* Rewrote SubjectsStep to tsx format

* fix sonar issue

* fix sonar issue 2
* Rewrote FindBlock to tsx format

* fixed tests
* Rewrote ProfileDoneItemsList to tsx format

* changed imports
* Fixed privacy policy translation

* Fixed en version
* Add an error tooltip for User Profile

* Add open on hover behaviour

* Fix style: added gap and decreased error icon

* Add an error tooltip to the personal info tab

* Fix test

* Fix linter errors

* Update src/pages/edit-profile/EditProfile.tsx

Co-authored-by: Olenka Hryk <[email protected]>

* Refactor enableTooltipError to use optional chain expression

---------

Co-authored-by: Olenka Hryk <[email protected]>
* Rewrote ProfileContainerMobile to tsx

* Refactor doneItems type

* Fix doneItems type
* Rewrote ProfileContainerDesktop to tsx

* Refactor doneItems type

* Fix doneItems type
…category-name

Bugfix/2113/change category name
…e-login-form-tsx

Rewrite LoginForm to tsx format and fix the sonar issues
…e-google-login-tsx

Rewrite GoogleLogin to tsx format and fix the sonar issues
…e-offer-details-tsx

Rewrite OfferDetails to tsx format and fix the sonar issues
* Rewrote SearchInput to tsx

* Refactor setSearch to use React.Dispatch type
Copy link

sonarqubecloud bot commented Aug 2, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
70.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@YulichkaR YulichkaR closed this Aug 2, 2024
@YulichkaR YulichkaR deleted the bugfix/2215/correct-pluralisation-of-offer-counts branch August 2, 2024 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Frontend part
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants