-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Corrected pluralisation of offer counts in EN and UA Translations #2268
Closed
YulichkaR
wants to merge
38
commits into
develop
from
bugfix/2215/correct-pluralisation-of-offer-counts
Closed
Corrected pluralisation of offer counts in EN and UA Translations #2268
YulichkaR
wants to merge
38
commits into
develop
from
bugfix/2215/correct-pluralisation-of-offer-counts
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YulichkaR
requested review from
Olenka-Hryk,
YaroslavChuiko,
dudchakk,
ipasic-softserve,
docia,
abalanovsky,
PavloDolia,
BohdanMylyi and
Mike-Popovych
August 1, 2024 13:53
2 tasks
PavloDolia
approved these changes
Aug 1, 2024
* rewrote DateFilter to tsx * extended DesktopDatePickerProps
* Rewrote SubjectsStep to tsx format * fix sonar issue * fix sonar issue 2
* Rewrote FindBlock to tsx format * fixed tests
* Rewrote ProfileDoneItemsList to tsx format * changed imports
* Fixed privacy policy translation * Fixed en version
* Add an error tooltip for User Profile * Add open on hover behaviour * Fix style: added gap and decreased error icon * Add an error tooltip to the personal info tab * Fix test * Fix linter errors * Update src/pages/edit-profile/EditProfile.tsx Co-authored-by: Olenka Hryk <[email protected]> * Refactor enableTooltipError to use optional chain expression --------- Co-authored-by: Olenka Hryk <[email protected]>
* Rewrote ProfileContainerMobile to tsx * Refactor doneItems type * Fix doneItems type
* Rewrote ProfileContainerDesktop to tsx * Refactor doneItems type * Fix doneItems type
…category-name Bugfix/2113/change category name
…e-login-form-tsx Rewrite LoginForm to tsx format and fix the sonar issues
…e-google-login-tsx Rewrite GoogleLogin to tsx format and fix the sonar issues
…e-offer-details-tsx Rewrite OfferDetails to tsx format and fix the sonar issues
* Rewrote SearchInput to tsx * Refactor setSearch to use React.Dispatch type
…ttps://github.com/ita-social-projects/SpaceToStudy-Client into bugfix/2215/correct-pluralisation-of-offer-counts
Quality Gate failedFailed conditions |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After: