Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated redux and redux toolkit #2248

Conversation

YaroslavLys
Copy link
Contributor

@YaroslavLys YaroslavLys commented Jul 29, 2024

Done

Updated redux and redux toolkit.

Manual override of dependecies

There was a typescript issue during the update to redux toolkit v2, which was related to the incompatibility of redux thunk middleware with redux toolkit v2. It was solved by manually overriding dependancies as described in official documentation about migrating to redux toolkit v2:
https://redux-toolkit.js.org/usage/migrating-rtk-2#overriding-dependencies

Passage from documentation:

It will take a while for packages to update their peer dependencies to allow for Redux core 5.0, and in the meantime changes like the Middleware type will result in perceived incompatibilities.

It's likely that most libraries will not actually have any practices that are incompatible with 5.0, but due to the peer dependency on 4.0 they end up pulling in old type declarations.

This can be solved by manually overriding the dependency resolution, which is supported by both npm and yarn.

Other discussions about similar issues:
https://stackoverflow.com/questions/77691124/type-error-redux-saga-middleware-with-typescript
reduxjs/redux-toolkit#3950 (comment)

Olenka-Hryk and others added 4 commits July 29, 2024 14:12
@YaroslavLys YaroslavLys linked an issue Jul 29, 2024 that may be closed by this pull request
Copy link

sonarqubecloud bot commented Aug 7, 2024

@YaroslavLys YaroslavLys merged commit a75a2fe into feature/2140/update-dependencies Aug 7, 2024
3 checks passed
@YaroslavLys YaroslavLys deleted the feature/2123/sp-1-update-redux-and-redux-toolkit branch August 7, 2024 15:27
YaroslavChuiko added a commit that referenced this pull request Oct 4, 2024
* updated @typescript-eslint/eslint-plugin and @typescript-eslint/parser

* fixed eslint errors

* Updated redux and redux toolkit

* Expanded workflow triggers to include feature branches #2186 (#2187)

* Expanded workflow triggers to include feature branches #2186

* Optimization of workflow process

* delete sonar.branch.name (#2232)

* Fixed sonar issue

---------

Co-authored-by: YaroslavChuiko <[email protected]>
Co-authored-by: Olenka Hryk <[email protected]>
Co-authored-by: Yaroslav Chuiko <[email protected]>
YaroslavChuiko added a commit that referenced this pull request Oct 8, 2024
* updated @typescript-eslint/eslint-plugin and @typescript-eslint/parser

* fixed eslint errors

* Updated redux and redux toolkit

* Expanded workflow triggers to include feature branches #2186 (#2187)

* Expanded workflow triggers to include feature branches #2186

* Optimization of workflow process

* delete sonar.branch.name (#2232)

* Fixed sonar issue

---------

Co-authored-by: YaroslavChuiko <[email protected]>
Co-authored-by: Olenka Hryk <[email protected]>
Co-authored-by: Yaroslav Chuiko <[email protected]>
YaroslavChuiko added a commit that referenced this pull request Oct 11, 2024
* updated @typescript-eslint/eslint-plugin and @typescript-eslint/parser

* fixed eslint errors

* Updated dependencies related to testing (#2161)

* updated dependencies related to testing

* Installed @testing-library/dom

* fixed warning

* updated Vite package (#2167)

* Updated eslint package, migrated to the new eslint config system (#2196)

* updated eslint package, migrated to the new eslint config system

* excluded eslint.config.mjs from sonarCloud coverage check

* updated @tinymce/tinymce-react package (#2169)

* updated husky package, updated husky hooks (#2218)

* updated i18next and react-i18next packages (#2255)

* updated jsdom package (#2257)

* updated jsdom package

* fixed unit test

* updated web-vitals package (#2253)

* Update date dependencies (#2252)

* Updated date dependencies, refactored

* Deleted npm check updates

* Fixed DateFilter tests

* Updated redux and redux toolkit (#2248)

* updated @typescript-eslint/eslint-plugin and @typescript-eslint/parser

* fixed eslint errors

* Updated redux and redux toolkit

* Expanded workflow triggers to include feature branches #2186 (#2187)

* Expanded workflow triggers to include feature branches #2186

* Optimization of workflow process

* delete sonar.branch.name (#2232)

* Fixed sonar issue

---------

Co-authored-by: YaroslavChuiko <[email protected]>
Co-authored-by: Olenka Hryk <[email protected]>
Co-authored-by: Yaroslav Chuiko <[email protected]>

* Updated nuka-carousel package (#2266)

* Updated nuka-carousel package

* Updated @types/react-swipeable-views package (#2254)

* Revert "Update date dependencies (#2252)"

This reverts commit bbd8bb7.

* update prepare script

* removed redundant useMemo

* fix eslint error

* fixed tests

* fixed scss deprecation warning

* updated node to v20.15.1 for docker compose and github actions

* updated package-lock.json

* fixed eslint errors

* fixed tests

* updated coverage exclusions

* Feature/enhancing test and build speed (#2581)

* Update main.yaml

adding caching and npm and removing deprecated job with docker

* deleted test branch

* Update main.yaml (#2583)

adding linter job

* Update main.yaml

* fixed error

---------

Co-authored-by: Artem Balanovskyi <[email protected]>
Co-authored-by: YaroslavLys <[email protected]>
Co-authored-by: Olenka Hryk <[email protected]>
Co-authored-by: Illia Pasichnichenko <[email protected]>
Co-authored-by: new-user888 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(SP: 1) Update redux and redux toolkit
5 participants