-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated redux and redux toolkit #2248
Merged
YaroslavLys
merged 8 commits into
feature/2140/update-dependencies
from
feature/2123/sp-1-update-redux-and-redux-toolkit
Aug 7, 2024
Merged
Updated redux and redux toolkit #2248
YaroslavLys
merged 8 commits into
feature/2140/update-dependencies
from
feature/2123/sp-1-update-redux-and-redux-toolkit
Aug 7, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YaroslavLys
requested review from
maarekua,
Olenka-Hryk,
YaroslavChuiko,
byavdoshniak,
docia,
abalanovsky,
Mav-Ivan and
Mike-Popovych
July 29, 2024 11:00
…1-update-redux-and-redux-toolkit
abalanovsky
approved these changes
Jul 30, 2024
YaroslavChuiko
approved these changes
Jul 30, 2024
docia
approved these changes
Jul 31, 2024
…1-update-redux-and-redux-toolkit
Quality Gate passedIssues Measures |
YaroslavLys
deleted the
feature/2123/sp-1-update-redux-and-redux-toolkit
branch
August 7, 2024 15:27
YaroslavChuiko
added a commit
that referenced
this pull request
Oct 4, 2024
* updated @typescript-eslint/eslint-plugin and @typescript-eslint/parser * fixed eslint errors * Updated redux and redux toolkit * Expanded workflow triggers to include feature branches #2186 (#2187) * Expanded workflow triggers to include feature branches #2186 * Optimization of workflow process * delete sonar.branch.name (#2232) * Fixed sonar issue --------- Co-authored-by: YaroslavChuiko <[email protected]> Co-authored-by: Olenka Hryk <[email protected]> Co-authored-by: Yaroslav Chuiko <[email protected]>
YaroslavChuiko
added a commit
that referenced
this pull request
Oct 8, 2024
* updated @typescript-eslint/eslint-plugin and @typescript-eslint/parser * fixed eslint errors * Updated redux and redux toolkit * Expanded workflow triggers to include feature branches #2186 (#2187) * Expanded workflow triggers to include feature branches #2186 * Optimization of workflow process * delete sonar.branch.name (#2232) * Fixed sonar issue --------- Co-authored-by: YaroslavChuiko <[email protected]> Co-authored-by: Olenka Hryk <[email protected]> Co-authored-by: Yaroslav Chuiko <[email protected]>
YaroslavChuiko
added a commit
that referenced
this pull request
Oct 11, 2024
* updated @typescript-eslint/eslint-plugin and @typescript-eslint/parser * fixed eslint errors * Updated dependencies related to testing (#2161) * updated dependencies related to testing * Installed @testing-library/dom * fixed warning * updated Vite package (#2167) * Updated eslint package, migrated to the new eslint config system (#2196) * updated eslint package, migrated to the new eslint config system * excluded eslint.config.mjs from sonarCloud coverage check * updated @tinymce/tinymce-react package (#2169) * updated husky package, updated husky hooks (#2218) * updated i18next and react-i18next packages (#2255) * updated jsdom package (#2257) * updated jsdom package * fixed unit test * updated web-vitals package (#2253) * Update date dependencies (#2252) * Updated date dependencies, refactored * Deleted npm check updates * Fixed DateFilter tests * Updated redux and redux toolkit (#2248) * updated @typescript-eslint/eslint-plugin and @typescript-eslint/parser * fixed eslint errors * Updated redux and redux toolkit * Expanded workflow triggers to include feature branches #2186 (#2187) * Expanded workflow triggers to include feature branches #2186 * Optimization of workflow process * delete sonar.branch.name (#2232) * Fixed sonar issue --------- Co-authored-by: YaroslavChuiko <[email protected]> Co-authored-by: Olenka Hryk <[email protected]> Co-authored-by: Yaroslav Chuiko <[email protected]> * Updated nuka-carousel package (#2266) * Updated nuka-carousel package * Updated @types/react-swipeable-views package (#2254) * Revert "Update date dependencies (#2252)" This reverts commit bbd8bb7. * update prepare script * removed redundant useMemo * fix eslint error * fixed tests * fixed scss deprecation warning * updated node to v20.15.1 for docker compose and github actions * updated package-lock.json * fixed eslint errors * fixed tests * updated coverage exclusions * Feature/enhancing test and build speed (#2581) * Update main.yaml adding caching and npm and removing deprecated job with docker * deleted test branch * Update main.yaml (#2583) adding linter job * Update main.yaml * fixed error --------- Co-authored-by: Artem Balanovskyi <[email protected]> Co-authored-by: YaroslavLys <[email protected]> Co-authored-by: Olenka Hryk <[email protected]> Co-authored-by: Illia Pasichnichenko <[email protected]> Co-authored-by: new-user888 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
Updated redux and redux toolkit.
Manual override of dependecies
There was a typescript issue during the update to redux toolkit v2, which was related to the incompatibility of redux thunk middleware with redux toolkit v2. It was solved by manually overriding dependancies as described in official documentation about migrating to redux toolkit v2:
https://redux-toolkit.js.org/usage/migrating-rtk-2#overriding-dependencies
Passage from documentation:
Other discussions about similar issues:
https://stackoverflow.com/questions/77691124/type-error-redux-saga-middleware-with-typescript
reduxjs/redux-toolkit#3950 (comment)